Bug 1315225

Summary: firefox build failure on ppc64le/arm64
Product: [Fedora] Fedora Reporter: Than Ngo <than>
Component: firefoxAssignee: Martin Stransky <stransky>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: dhorak, gecko-bugs-nobody, jhorak, kparal, mjuszkie, pbrobinson, pjasicek, stransky, than
Target Milestone: ---   
Target Release: ---   
Hardware: ppc64le   
OS: All   
Whiteboard: AcceptedFreezeException
Fixed In Version: firefox-46.0-4.fc24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-03 18:05:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1071880, 922257, 1230434    

Description Than Ngo 2016-03-07 09:47:21 UTC
firefox-45.0-4 doesn't build on ppc64le in f24, it breaks with following errors:

Executing /builddir/build/BUILD/firefox-45.0/firefox-45.0/objdir/dist/bin/xpcshell -g /builddir/build/BUILD/firefox-45.0/firefox-45.0/objdir/dist/bin/ -a /builddir/build/BUILD/firefox-45.0/firefox-45.0/objdir/dist/bin/ -f /builddir/build/BUILD/firefox-45.0/firefox-45.0/toolkit/mozapps/installer/precompile_cache.js -e precompile_startupcache("resource://gre/");
No such property on self-hosted object: undefined
Traceback (most recent call last):
  File "/builddir/build/BUILD/firefox-45.0/firefox-45.0/toolkit/mozapps/installer/packager.py", line 406, in <module>
    main()
  File "/builddir/build/BUILD/firefox-45.0/firefox-45.0/toolkit/mozapps/installer/packager.py", line 400, in main
    args.source, gre_path, base)
  File "/builddir/build/BUILD/firefox-45.0/firefox-45.0/toolkit/mozapps/installer/packager.py", line 161, in precompile_cache
    errors.fatal('Error while running startup cache precompilation')
  File "/builddir/build/BUILD/firefox-45.0/firefox-45.0/python/mozbuild/mozpack/errors.py", line 103, in fatal
    self._handle(self.FATAL, msg)
  File "/builddir/build/BUILD/firefox-45.0/firefox-45.0/python/mozbuild/mozpack/errors.py", line 98, in _handle
    raise ErrorMessage(msg)
mozpack.errors.ErrorMessage: Error: Error while running startup cache precompilation


For more infos please take a look at:
 http://ppc.koji.fedoraproject.org/kojifiles/work/tasks/2214/3202214/build.log

Comment 1 Peter Robinson 2016-04-09 19:59:10 UTC
And aarch64 http://arm.koji.fedoraproject.org/koji/buildinfo?buildID=366928

Comment 2 Fedora Blocker Bugs Application 2016-04-09 20:00:10 UTC
Proposed as a Freeze Exception for 24-beta by Fedora user pbrobinson using the blocker tracking app because:

 Secondary architecture. Primary browser must be working.

Comment 3 Martin Stransky 2016-04-11 07:46:03 UTC
I guess it's caused by gcc6 compiler. I see the builds went fine some time ago but all builds fail now.

Comment 4 Kamil Páral 2016-04-18 16:53:04 UTC
Discussed at today's blocker review meeting [1]. Voted as AcceptedFreezeException (Beta) - Firefox is the default browser for most desktops, and this bug prevents its inclusion in secondary-arch images. issues that seriously affect the compose of secondary arch deliverables generally qualify for FE status.

[1] https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2016-04-18

Comment 5 Fedora Update System 2016-04-18 19:31:42 UTC
firefox-45.0.2-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-cebfb38250

Comment 6 Peter Robinson 2016-04-19 12:12:23 UTC
(In reply to Fedora Update System from comment #5)
> firefox-45.0.2-2.fc24 has been submitted as an update to Fedora 24.
> https://bodhi.fedoraproject.org/updates/FEDORA-2016-cebfb38250

The firefox-45.0.2-2.fc24 build doesn't fix this problem, at least on aarch64

http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=3508596

Comment 7 Peter Robinson 2016-04-19 13:35:51 UTC
Doesn't build on Power64 either
http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=3310296

Comment 8 Martin Stransky 2016-04-19 19:58:11 UTC
Looks like wrong memory layout here:

Assertion failure: size % pageSize == 0, at /root/rpmbuild/BUILD/firefox-45.0.2/firefox-45.0.2/js/src/gc/Memory.cpp:757

Thread 1 "js" received signal SIGSEGV, Segmentation fault.
0x0000000020a503e0 in js::gc::ProtectPages (p=<optimized out>, size=<optimized out>)
    at /root/rpmbuild/BUILD/firefox-45.0.2/firefox-45.0.2/js/src/gc/Memory.cpp:757
757	    MOZ_ASSERT(size % pageSize == 0);

Comment 9 Peter Robinson 2016-04-19 21:16:28 UTC
(In reply to Martin Stransky from comment #8)
> Looks like wrong memory layout here:

Both aarch64 and Powwer64 are 64k page sizes

Comment 10 Martin Stransky 2016-04-21 11:29:39 UTC
*** Bug 1320953 has been marked as a duplicate of this bug. ***

Comment 11 Martin Stransky 2016-04-26 14:20:59 UTC
Looks like the recent -O3 optimization is too aggressive/buggy on gcc6 for aarch64. We need to switch to -O2 temporary for JS engine.

Comment 12 Dan Horák 2016-04-27 08:09:35 UTC
still getting the failure on ppc64le with firefox-46.0-2.fc24

Comment 13 Martin Stransky 2016-04-27 09:27:04 UTC
Added fix to firefox-46.0-4 - please test on ppc.koji.

Comment 14 Peter Robinson 2016-04-27 09:28:29 UTC
(In reply to Martin Stransky from comment #13)
> Added fix to firefox-46.0-4 - please test on ppc.koji.

Do you mean -3 as there's no -4 there
http://koji.fedoraproject.org/koji/packageinfo?packageID=37

Comment 15 Martin Stransky 2016-04-27 09:31:50 UTC
No, I really mean -4 which goes to koji now. Unfortunately koji don't allow me to cancel already submitted builds.

Comment 16 Peter Robinson 2016-04-27 09:34:35 UTC
(In reply to Martin Stransky from comment #15)
> No, I really mean -4 which goes to koji now. Unfortunately koji don't allow
> me to cancel already submitted builds.

Yes, it does: "koji cancel <parent task ID>"

Comment 18 Than Ngo 2016-04-27 10:54:52 UTC
i confirm the fix. the latest firefox-46.0-4 built fine on ppc now

Comment 19 Peter Robinson 2016-04-27 11:29:11 UTC
So Power and aarch64 look fine. s390 and s390x are still failing.

s390x failure http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2195391

Comment 20 Peter Robinson 2016-04-27 12:14:33 UTC
I believe we also need similar fixes for thunderbird/xulrunner

Comment 21 Dan Horák 2016-04-27 12:35:21 UTC
(In reply to Peter Robinson from comment #19)
> So Power and aarch64 look fine. s390 and s390x are still failing.
> 
> s390x failure http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2195391

this is a buildroot issue with f25 not being fullu up-to-date

Comment 22 Peter Robinson 2016-04-27 18:07:42 UTC
Can we get this submitted as an update for F-24 please

Comment 23 Peter Robinson 2016-04-27 18:08:18 UTC
Sorry, wrong needinfo, Martin it was for you

Comment 24 Fedora Update System 2016-04-27 19:14:31 UTC
firefox-46.0-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0f939ef633

Comment 25 Martin Stransky 2016-04-28 08:58:53 UTC
Why do you needinfo me when you do the update yourself.

Comment 26 Peter Robinson 2016-04-28 09:14:37 UTC
(In reply to Martin Stransky from comment #25)
> Why do you needinfo me when you do the update yourself.

I put the needinfo on about 2hrs before I did the update

Comment 27 Fedora Update System 2016-04-28 16:26:05 UTC
firefox-46.0-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0f939ef633

Comment 28 Fedora Update System 2016-05-03 18:05:45 UTC
firefox-46.0-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.