Bug 1316029

Summary: vdsm - caps/machinetype API changes broke setup
Product: [Retired] ovirt-live Reporter: Sandro Bonazzola <sbonazzo>
Component: GeneralAssignee: Sandro Bonazzola <sbonazzo>
Status: CLOSED CURRENTRELEASE QA Contact: Sandro Bonazzola <sbonazzo>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 4.0.0CC: bugs, fromani, mpoledni
Target Milestone: ovirt-4.0.0-alphaKeywords: CodeChange, Regression
Target Release: 4.0.0Flags: rule-engine: ovirt-4.0.0+
rule-engine: blocker+
rule-engine: planning_ack+
sbonazzo: devel_ack+
pstehlik: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt 4.0.0 alpha1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-07 09:01:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Sandro Bonazzola 2016-03-09 09:51:54 UTC
Description of problem:
    caps/machinetype: move machine-type related code to new module
    Change-Id: Ia7bf79c66a38329672e1fbd3fd41a94058803b58
    Signed-off-by: Martin Polednik <mpolednik>
    Reviewed-on: https://gerrit.ovirt.org/54212

Actual results:
 Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 146, in _executeMethod
    method['method']()
  File "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-engine/all-in-one/cpu.py", line 134, in _validation
    cpu, compatible = self._getCompatibleCpuModels()
  File "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-engine/all-in-one/cpu.py", line 97, in _getCompatibleCpuModels
    caps._getCompatibleCpuModels(),
 AttributeError: 'module' object has no attribute '_getCompatibleCpuModels'

Comment 1 Francesco Romani 2016-03-09 10:03:24 UTC
(In reply to Sandro Bonazzola from comment #0)
> Description of problem:
>     caps/machinetype: move machine-type related code to new module
>     Change-Id: Ia7bf79c66a38329672e1fbd3fd41a94058803b58
>     Signed-off-by: Martin Polednik <mpolednik>
>     Reviewed-on: https://gerrit.ovirt.org/54212
> 
> Actual results:
>  Traceback (most recent call last):
>   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 146, in
> _executeMethod
>     method['method']()
>   File
> "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-
> engine/all-in-one/cpu.py", line 134, in _validation
>     cpu, compatible = self._getCompatibleCpuModels()
>   File
> "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-
> engine/all-in-one/cpu.py", line 97, in _getCompatibleCpuModels
>     caps._getCompatibleCpuModels(),
>  AttributeError: 'module' object has no attribute '_getCompatibleCpuModels'

So the setup was using a private unsupported caps.py function?

Comment 2 Sandro Bonazzola 2016-03-09 10:08:14 UTC
(In reply to Francesco Romani from comment #1)
> So the setup was using a private unsupported caps.py function?

It's oVirt Live. I see it's now public: vdsm.machinetype.getCompatibleCpuModels()

Comment 3 Sandro Bonazzola 2016-03-09 12:57:03 UTC
final API is vdsm.machinetype.compatible_cpu_models()

Comment 4 Pavel Stehlik 2016-06-22 11:51:05 UTC
CodeChange, nothing for QE.