Bug 1316029 - vdsm - caps/machinetype API changes broke setup
Summary: vdsm - caps/machinetype API changes broke setup
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-live
Classification: Retired
Component: General
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ovirt-4.0.0-alpha
: 4.0.0
Assignee: Sandro Bonazzola
QA Contact: Sandro Bonazzola
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-09 09:51 UTC by Sandro Bonazzola
Modified: 2017-05-11 09:24 UTC (History)
3 users (show)

Fixed In Version: ovirt 4.0.0 alpha1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-07 09:01:06 UTC
oVirt Team: Integration
rule-engine: ovirt-4.0.0+
rule-engine: blocker+
rule-engine: planning_ack+
sbonazzo: devel_ack+
pstehlik: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 54517 0 master MERGED setup: vdsm: update cpu/machinetype API 2016-03-09 12:56:09 UTC

Description Sandro Bonazzola 2016-03-09 09:51:54 UTC 
Description of problem:
    caps/machinetype: move machine-type related code to new module
    Change-Id: Ia7bf79c66a38329672e1fbd3fd41a94058803b58
    Signed-off-by: Martin Polednik <mpolednik>
    Reviewed-on: https://gerrit.ovirt.org/54212

Actual results:
 Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 146, in _executeMethod
    method['method']()
  File "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-engine/all-in-one/cpu.py", line 134, in _validation
    cpu, compatible = self._getCompatibleCpuModels()
  File "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-engine/all-in-one/cpu.py", line 97, in _getCompatibleCpuModels
    caps._getCompatibleCpuModels(),
 AttributeError: 'module' object has no attribute '_getCompatibleCpuModels'
Comment 1 Francesco Romani 2016-03-09 10:03:24 UTC 
(In reply to Sandro Bonazzola from comment #0)
> Description of problem:
>     caps/machinetype: move machine-type related code to new module
>     Change-Id: Ia7bf79c66a38329672e1fbd3fd41a94058803b58
>     Signed-off-by: Martin Polednik <mpolednik>
>     Reviewed-on: https://gerrit.ovirt.org/54212
> 
> Actual results:
>  Traceback (most recent call last):
>   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 146, in
> _executeMethod
>     method['method']()
>   File
> "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-
> engine/all-in-one/cpu.py", line 134, in _validation
>     cpu, compatible = self._getCompatibleCpuModels()
>   File
> "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-
> engine/all-in-one/cpu.py", line 97, in _getCompatibleCpuModels
>     caps._getCompatibleCpuModels(),
>  AttributeError: 'module' object has no attribute '_getCompatibleCpuModels'

So the setup was using a private unsupported caps.py function?
Comment 2 Sandro Bonazzola 2016-03-09 10:08:14 UTC 
(In reply to Francesco Romani from comment #1)
> So the setup was using a private unsupported caps.py function?

It's oVirt Live. I see it's now public: vdsm.machinetype.getCompatibleCpuModels()
Comment 3 Sandro Bonazzola 2016-03-09 12:57:03 UTC 
final API is vdsm.machinetype.compatible_cpu_models()
Comment 4 Pavel Stehlik 2016-06-22 11:51:05 UTC 
CodeChange, nothing for QE.
Note You need to log in before you can comment on or make changes to this bug.