Bug 1316074
| Summary: | DHCP range and NTP host changed between two runs of fusor-installer | ||
|---|---|---|---|
| Product: | Red Hat Quickstart Cloud Installer | Reporter: | Antonin Pagac <apagac> |
| Component: | fusor-installer | Assignee: | Jason Montleon <jmontleo> |
| Status: | CLOSED WONTFIX | QA Contact: | Dave Johnson <dajohnso> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 1.0 | CC: | apagac, jesusr, jmatthew |
| Target Milestone: | ga | Keywords: | Triaged |
| Target Release: | 1.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-03-29 20:16:46 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1315447 | ||
|
Description
Antonin Pagac
2016-03-09 11:17:26 UTC
What does your fusor-installer.answers.yaml file look like in /etc/katello-installer? I don't think the values get written until you get passed the ntp test. I know on rerun the value of my NTP sync host is saved, though I admit to generally accepting the DHCP range suggestions so I can't be positive in the case of those.
If I modify these I get the results I would expect:
"foreman::plugin::fusor":
from: "192.168.252.100"
to: "192.168.252.253"
ntp_host: clock.corp.redhat.com
You're right, values don't get written if you don't pass the NTP check. When I choose to continue with installation, my DHCP range gets written to the file and fusor-installer remembers it on another run. If I modify these settings and run fusor-installer again, going through the NTP check, values get changed and written. This works as expected. If you don't pass the NTP check and run fusor-installer again, the range does change to something you did not input there before. Is it OK to close this? Jason, you can close this if we are sure this is the behavior we want: 1. Run fusor-installer 2. Input non-default dhcp range manually 3. For whatever reason, fail the NTP check and choose to stop installation 4. On re-run of the fusor-installer, default values of dhcp are pre-filled and you must change them to your non-default values, if you so desire. In my opinion, this might cause some confusion, when user expect to have the same values he entered into the fusor-installer when re-running it. He might not check the values and network problems might arise upon completing the installation. I am split on this. On one hand I can see wanting to save the data sooner. We can probably manage to do this. On the other hand, if it does get stopped because it doesn't proceed through the NTP there is a high probability we're saving bad data. There's also a possibility of a rewrite of the installer not too far down the road. I'll get some input from the team and see what we want to do. The installation is effectively canceled when the user chooses not to proceed. If you enter a bunch of values and choose 20 to Cancel Installation. The same thing happens we lose the values. IMO, I think this is not a bug. |