Description of problem: On first run of the installer I deliberately input invalid NTP host, then choose to not continue with installation. When I ran fusor-installer for the second time, IP values for DHCP range changed from what I typed before and also the NTP host changed. Version-Release number of selected component (if applicable): TP2 RC9 How reproducible: Always Steps to Reproduce: 1. Run fusor-installer, input invalid NTP host, choose 'No' when asked to continue 2. Run fusor-installer again 3. Actual results: DHCP range is changed, it is different from what user typed on first run of the fusor-installer; NTP host is also different Expected results: DHCP range and NTP host should stay the same as user typed on the first run of fusor-installer Additional info: from console: Modify settings as needed, and then proceed with the installation: 1. Proceed with the values shown 2. Network interface | eth1 3. IP address | 192.168.145.2 4. Hostname | <retracted> 5. Network mask | 255.255.255.0 6. Network address | 192.168.145.0 7. Host gateway | 192.168.145.1 8. DHCP range start | 192.168.145.100 9. DHCP range end | 192.168.145.200 10. DHCP gateway | 192.168.145.2 11. DNS forwarder | <retracted> 12. Domain | <retracted> 13. Foreman URL | <retracted> 14. NTP sync host | <INVALID NTP HOST> 15. Time zone | US/Eastern 16. BMC feature enabled | false 17. BMC default provider | ipmitool 18. Do not configure networking 19. Do not configure firewall 20. Cancel installation 1 Starting networking setup Networking setup has finished WARNING!! - NTP sync host "<INVALID NTP HOST>" does not appear to be valid! Do you want to continue anyway? [Yes/No] No Exiting installation! Something went wrong! Check the log for ERROR-level output The full log is at /var/log/katello-installer/katello-installer.log [root@localhost ~]# fusor-installer --foreman-admin-password=<retracted> Select which NIC to use for provisioning: 1. eth0 2. eth1 ? 2 The installer can configure the networking and firewall rules on this machine with the configuration shown below. Default values are populated from this machine's existing networking configuration. If you DO NOT want to configure networking, select the option 'Do not configure networking' from the list below. Modify settings as needed, and then proceed with the installation: 1. Proceed with the values shown 2. Network interface | eth1 3. IP address | 192.168.145.2 4. Hostname | <retracted> 5. Network mask | 255.255.255.0 6. Network address | 192.168.145.0 7. Host gateway | 192.168.145.1 8. DHCP range start | 192.168.145.3 9. DHCP range end | 192.168.145.254 10. DHCP gateway | 192.168.145.2 11. DNS forwarder | <retracted> 12. Domain | <retracted> 13. Foreman URL | <retracted> 14. NTP sync host | 0.rhel.pool.ntp.org 15. Time zone | US/Eastern 16. BMC feature enabled | false 17. BMC default provider | ipmitool 18. Do not configure networking 19. Do not configure firewall 20. Cancel installation
What does your fusor-installer.answers.yaml file look like in /etc/katello-installer? I don't think the values get written until you get passed the ntp test. I know on rerun the value of my NTP sync host is saved, though I admit to generally accepting the DHCP range suggestions so I can't be positive in the case of those. If I modify these I get the results I would expect: "foreman::plugin::fusor": from: "192.168.252.100" to: "192.168.252.253" ntp_host: clock.corp.redhat.com
You're right, values don't get written if you don't pass the NTP check. When I choose to continue with installation, my DHCP range gets written to the file and fusor-installer remembers it on another run. If I modify these settings and run fusor-installer again, going through the NTP check, values get changed and written. This works as expected. If you don't pass the NTP check and run fusor-installer again, the range does change to something you did not input there before.
Is it OK to close this?
Jason, you can close this if we are sure this is the behavior we want: 1. Run fusor-installer 2. Input non-default dhcp range manually 3. For whatever reason, fail the NTP check and choose to stop installation 4. On re-run of the fusor-installer, default values of dhcp are pre-filled and you must change them to your non-default values, if you so desire. In my opinion, this might cause some confusion, when user expect to have the same values he entered into the fusor-installer when re-running it. He might not check the values and network problems might arise upon completing the installation.
I am split on this. On one hand I can see wanting to save the data sooner. We can probably manage to do this. On the other hand, if it does get stopped because it doesn't proceed through the NTP there is a high probability we're saving bad data. There's also a possibility of a rewrite of the installer not too far down the road. I'll get some input from the team and see what we want to do.
The installation is effectively canceled when the user chooses not to proceed. If you enter a bunch of values and choose 20 to Cancel Installation. The same thing happens we lose the values. IMO, I think this is not a bug.