Bug 1316196
| Summary: | Review Request: shrinkwrap-resolver - Java API to obtain Maven artifacts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | gil cattaneo <puntogil> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kpiwko, mjobanek, package-review, zbyszek |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | zbyszek:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-04-13 21:34:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1316195 | ||
|
Description
gil cattaneo
2016-03-09 16:13:05 UTC
shrinkwrap-resolver [f23, master] was unorphaned by limb ShrinkWrap Resolver https://admin.fedoraproject.org/pkgdb/package/shrinkwrap-resolver https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/G4RNANNW2A4KFMCYQA442CW6PBTQWPLW/ 2016-03-10 15:37:56 user: limb changed point of contact of package: shrinkwrap-resolver from: orphan to: gil on branch: master https://admin.fedoraproject.org/pkgdb/package/rpms/shrinkwrap-resolver/timeline this review does not look right. (In reply to Raphael Groner from comment #3) > shrinkwrap-resolver [f23, master] was unorphaned by limb > ShrinkWrap Resolver > https://admin.fedoraproject.org/pkgdb/package/shrinkwrap-resolver > > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ > message/G4RNANNW2A4KFMCYQA442CW6PBTQWPLW/ > > 2016-03-10 15:37:56 user: limb changed point of contact of package: > shrinkwrap-resolver from: orphan to: gil on branch: master > > https://admin.fedoraproject.org/pkgdb/package/rpms/shrinkwrap-resolver/ > timeline The package must be reviewed https://fedorahosted.org/rel-eng/ticket/6379#comment:1 Sorry but I do not understand what's going on here, it's not the normal process. (In reply to Raphael Groner from comment #6) > Sorry but I do not understand what's going on here, it's not the normal > process. From https://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Retired_Package "Retired Fedora packages (master/devel/rawhide branch retired) require a re-review if they are retired for more than two weeks or if there is no previous review of the package. Submit a review request (a new bugzilla ticket) and have the package approved by a reviewer as if it were new to Fedora. See the package review process for more information. To unretire a EPEL branch if the package is still in Fedora, no re-review is required." The package was retired in 2015/07/28. This mean more of two weeks Side note: package was retired because it did not build for two releases. Now it builds again, so that reason is gone. So that's good.
Summary is useless. Proposed replacement: Java API to obtain maven artifacts.
Summaries and %descriptions for the subpackages are all pretty bad:
- Summary should not repeat the package name or expand the abbreviations
- It should succinctly summarize the purpose of the package
- %description should say what the (sub)package is used for
- %description should be wrapped to ~72 columns
I'd suggest using "%global _docdir_fmt %{name}" to avoid a separate license dir for each of the subpackages.
+ latest version
+ license is acceptable (ASL)
+ license file is present, %license is used
+ all subpackages have the license
+ package name follows guidelines
+ builds and installs OK
+ no scriptlets present or necessary
+ provides/requires look OK
+ standard maven build macros are used
- no %check, unfortunately
more interesting parts of fedora-review output:
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It
is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including metadata) even
when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms
rpmlint:
16×no-documentation and bogus spelling-errors, all OK
Package is (RE-)APPROVED. Please improve the Summaries and %descriptions.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #8) > Side note: package was retired because it did not build for two releases. > Now it builds again, so that reason is gone. So that's good. > > Summary is useless. Proposed replacement: Java API to obtain maven artifacts. Done > Summaries and %descriptions for the subpackages are all pretty bad: > - Summary should not repeat the package name or expand the abbreviations > - It should succinctly summarize the purpose of the package > - %description should say what the (sub)package is used for > - %description should be wrapped to ~72 columns Any suggestion is welcome! > Package is (RE-)APPROVED. Please improve the Summaries and %descriptions. Thanks for the review! LGTM. Thanks for the work guys! shrinkwrap-resolver-2.2.2-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f5e46208fa shrinkwrap-resolver-2.2.2-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-798ad6ebf9 shrinkwrap-resolver-2.2.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f5e46208fa shrinkwrap-resolver-2.2.2-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-798ad6ebf9 shrinkwrap-resolver-2.2.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. shrinkwrap-resolver-2.2.2-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |