Spec URL: https://gil.fedorapeople.org/arquillian-core.spec SRPM URL: https://gil.fedorapeople.org/arquillian-core-1.1.11-1.fc23.src.rpm Description: Arquillian is a revolutionary testing platform built on the JVM that substantially reduces the effort required to write and execute Java middle-ware integration and functional tests. No more mocks. No more container life-cycle and deployment hassles. Just real tests! Fedora Account System Username: gil
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=13296801 NOTE: shrinkwrap-resolver support, mvn(org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-bom:pom:), is temporarily disabled
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=13297822
Are you sure that license file gets installed with every packages combination, how to validate that?
FTBFS (rawhide), please explain how to build without shrinkwrap-resolver, needed in (bundled) jboss. [ERROR] /builddir/build/BUILD/arquillian-core-1.1.11.Final/config/impl-base/src/main/java/org/jboss/ arquillian/config/impl/extension/ConfigurationSysPropResolver.java:[55,101] cannot find symbol symbol: method fromString(java.lang.String) location: interface org.jboss.shrinkwrap.descriptor.api.DescriptorImporter<org.jboss.arquillian.co nfig.descriptor.api.ArquillianDescriptor> [ERROR] /builddir/build/BUILD/arquillian-core-1.1.11.Final/config/impl-base/src/main/java/org/jboss/ arquillian/config/impl/extension/ConfigurationRegistrar.java:[83,43] cannot find symbol symbol: method fromStream(java.io.InputStream) location: interface org.jboss.shrinkwrap.descriptor.api.DescriptorImporter<org.jboss.arquillian.co nfig.descriptor.api.ArquillianDescriptor>
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=13324173
(In reply to Raphael Groner from comment #3) > Are you sure that license file gets installed with every packages > combination, how to validate that? All sub-package "directly" require arquillian-core-api, see Requires section on the granerated review.txt file (In reply to Raphael Groner from comment #4) > FTBFS (rawhide), please explain how to build without shrinkwrap-resolver, > needed in (bundled) jboss. Is not neccessary, for now > [ERROR] > /builddir/build/BUILD/arquillian-core-1.1.11.Final/config/impl-base/src/main/ > java/org/jboss/ > arquillian/config/impl/extension/ConfigurationSysPropResolver.java:[55,101] > cannot find symbol > symbol: method fromString(java.lang.String) > location: interface > org.jboss.shrinkwrap.descriptor.api.DescriptorImporter<org.jboss.arquillian. > co > nfig.descriptor.api.ArquillianDescriptor> > [ERROR] > /builddir/build/BUILD/arquillian-core-1.1.11.Final/config/impl-base/src/main/ > java/org/jboss/ > arquillian/config/impl/extension/ConfigurationRegistrar.java:[83,43] cannot > find symbol > symbol: method fromStream(java.io.InputStream) > location: interface > org.jboss.shrinkwrap.descriptor.api.DescriptorImporter<org.jboss.arquillian. > co > nfig.descriptor.api.ArquillianDescriptor> Use old shrinkwrap-descriptor pkg (shrinkwrap-descriptors-2.0.0-0.13.alpha2.fc25)? because this release use shrinkwrap-descriptors-2.0.0-0.2.alpha8.fc25
(In reply to gil cattaneo from comment #6) > (In reply to Raphael Groner from comment #3) > > Are you sure that license file gets installed with every packages > > combination, how to validate that? > > All sub-package "directly" require arquillian-core-api, see Requires section > on the granerated review.txt file > > (In reply to Raphael Groner from comment #4) > > FTBFS (rawhide), please explain how to build without shrinkwrap-resolver, > > needed in (bundled) jboss. > Is not neccessary, for now because is not sure that we can continue to maintain wildfly (jboss-as) in Fedora, it is very likely to be completely abandoned
- Package does not use a name that already exists. Note: A package with this name already exists. Please check https://admin.fedoraproject.org/pkgdb/acls/name/arquillian-core See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names … and you're the package owner, why do you request this new review?
Created attachment 1138675 [details] licensecheck.txt Please explain the long lists for 'LGPL (v2.1 or later)' and 'Unknown or generated'. You use 'License: ASL 2.0', this is not sufficient.
(In reply to Raphael Groner from comment #8) > - Package does not use a name that already exists. > Note: A package with this name already exists. Please check > https://admin.fedoraproject.org/pkgdb/acls/name/arquillian-core > See: > > https://fedoraproject.org/wiki/Packaging/ > NamingGuidelines#Conflicting_Package_Names > > … and you're the package owner, why do you request this new review? See https://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Retired_Package (In reply to Raphael Groner from comment #9) > Created attachment 1138675 [details] > licensecheck.txt > > Please explain the long lists for 'LGPL (v2.1 or later)' and 'Unknown or > generated'. You use 'License: ASL 2.0', this is not sufficient. Everything there is to know is shown in the spec file: the only file "unlicensed" is ./testng/core/src/main/java/org/jboss/arquillian/testng/TestDataProviderTransformer.java report @ https://github.com/arquillian/arquillian-core/issues/100 (upstream fixed) The sub package arquillian-config-impl-base bundle jboss-common-core (i don't know the version) under LGPLv2 ./config/impl-base/src/main/java/org/jboss/arquillian/config/impl/extension/StringPropertyReplacer.java ./config/impl-base/src/main/java/org/jboss/arquillian/config/impl/extension/SysPropertyActions.java
To me, the package summary "Arquillian is a revolutionary testing platform built on the JVM" reads like an ad. Please use a more neutral description.
(In reply to Ralf Corsepius from comment #11) > To me, the package summary "Arquillian is a revolutionary testing platform > built on the JVM" reads like an ad. > > Please use a more neutral description. Sorry, but i leave the summary as it is
@ Raphael Please check the headers of those files (that are packaged) that are listed as unlicensed
Spec URL: https://gil.fedorapeople.org/arquillian-core.spec SRPM URL: https://gil.fedorapeople.org/arquillian-core-1.1.11-2.fc23.src.rpm - adjust some license fields
(In reply to gil cattaneo from comment #10) > (In reply to Raphael Groner from comment #8) > > - Package does not use a name that already exists. > > Note: A package with this name already exists. Please check > > https://admin.fedoraproject.org/pkgdb/acls/name/arquillian-core > > See: > > > > https://fedoraproject.org/wiki/Packaging/ > > NamingGuidelines#Conflicting_Package_Names > > > > … and you're the package owner, why do you request this new review? > > See > https://fedoraproject.org/wiki/ > Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Retired_Pa > ckage No. See https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/AGBPRXPQRJJTA6EEP7UQQ4YGDJHXOM6W/ You own the package since Friday, 4 March 2016, see date of the linked mail from the previous maintainer. I feel enforced to approve. This review request is unneeded and therefore invalid.
(In reply to Raphael Groner from comment #15) > (In reply to gil cattaneo from comment #10) > > (In reply to Raphael Groner from comment #8) > > > - Package does not use a name that already exists. > > > Note: A package with this name already exists. Please check > > > https://admin.fedoraproject.org/pkgdb/acls/name/arquillian-core > > > See: > > > > > > https://fedoraproject.org/wiki/Packaging/ > > > NamingGuidelines#Conflicting_Package_Names > > > > > > … and you're the package owner, why do you request this new review? > > > > See > > https://fedoraproject.org/wiki/ > > Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Retired_Pa > > ckage > > No. See > > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ > message/AGBPRXPQRJJTA6EEP7UQQ4YGDJHXOM6W/ > > You own the package since Friday, 4 March 2016, see date of the linked mail > from the previous maintainer. > > I feel enforced to approve. This review request is unneeded and therefore > invalid. The package must be reviewed, or the rel-eng staff cant un-block the package
Sorry but I do not understand what's going on here, it's not the normal process.
(In reply to Raphael Groner from comment #17) > Sorry but I do not understand what's going on here, it's not the normal > process. From https://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Retired_Package "Retired Fedora packages (master/devel/rawhide branch retired) require a re-review if they are retired for more than two weeks or if there is no previous review of the package. Submit a review request (a new bugzilla ticket) and have the package approved by a reviewer as if it were new to Fedora. See the package review process for more information. To unretire a EPEL branch if the package is still in Fedora, no re-review is required." The package was retired in 2015/07/29. This mean more of two weeks
Looking at the timeline in pkgdb, the package was retired by Till. 2015-07-29 20:55:03 user: till updated package: arquillian-core status from: Approved to Retired on branch: f23 2015-07-29 20:54:45 user: till updated package: arquillian-core status from: Approved to Retired on branch: master Since then, it has not had a re-review but for some reason the pkgdb branches have the status Approved. In any case, according to process, as mentioned in #18, this package needs to be re-reviewed. I am looking at the package now.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://admin.fedoraproject.org/pkgdb/acls/name/arquillian-core See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names ---> This is a re-review. This is fine. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "LGPL (v2.1 or later)", "Unknown or generated", "*No copyright* Apache (v2.0)". 38 files have unknown license. Detailed output of licensecheck in /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1316195-arquillian- core/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in arquillian-core-api , arquillian-core-impl-base , arquillian-core- parent , arquillian-core-spi , arquillian-bom , arquillian-build , arquillian-config-api , arquillian-config-impl-base , arquillian- config-parent , arquillian-config-spi , arquillian-container-impl-base , arquillian-container-parent , arquillian-container-spi , arquillian- container-test-api , arquillian-container-test-impl-base , arquillian- container-test-spi , arquillian-junit-container , arquillian-junit- core , arquillian-junit-parent , arquillian-junit-standalone , arquillian-parent , arquillian-protocol-jmx , arquillian-protocol- parent , arquillian-protocol-servlet , arquillian-test-api , arquillian-test-impl-base , arquillian-test-parent , arquillian-test- spi , arquillian-testenricher-cdi , arquillian-testenricher-ejb , arquillian-testenricher-initialcontext , arquillian-testenricher- parent , arquillian-testenricher-resource , arquillian-testng- container , arquillian-testng-core , arquillian-testng-parent , arquillian-testng-standalone , arquillian-core-javadoc ---> Going through the provides and requires below, all seems fine here. That's some complicated dep. scheme. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. ---> koji link provided. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) ---> uses maven. [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: arquillian-core-api-1.1.11-2.fc25.noarch.rpm arquillian-core-impl-base-1.1.11-2.fc25.noarch.rpm arquillian-core-parent-1.1.11-2.fc25.noarch.rpm arquillian-core-spi-1.1.11-2.fc25.noarch.rpm arquillian-bom-1.1.11-2.fc25.noarch.rpm arquillian-build-1.1.11-2.fc25.noarch.rpm arquillian-config-api-1.1.11-2.fc25.noarch.rpm arquillian-config-impl-base-1.1.11-2.fc25.noarch.rpm arquillian-config-parent-1.1.11-2.fc25.noarch.rpm arquillian-config-spi-1.1.11-2.fc25.noarch.rpm arquillian-container-impl-base-1.1.11-2.fc25.noarch.rpm arquillian-container-parent-1.1.11-2.fc25.noarch.rpm arquillian-container-spi-1.1.11-2.fc25.noarch.rpm arquillian-container-test-api-1.1.11-2.fc25.noarch.rpm arquillian-container-test-impl-base-1.1.11-2.fc25.noarch.rpm arquillian-container-test-spi-1.1.11-2.fc25.noarch.rpm arquillian-junit-container-1.1.11-2.fc25.noarch.rpm arquillian-junit-core-1.1.11-2.fc25.noarch.rpm arquillian-junit-parent-1.1.11-2.fc25.noarch.rpm arquillian-junit-standalone-1.1.11-2.fc25.noarch.rpm arquillian-parent-1.1.11-2.fc25.noarch.rpm arquillian-protocol-jmx-1.1.11-2.fc25.noarch.rpm arquillian-protocol-parent-1.1.11-2.fc25.noarch.rpm arquillian-protocol-servlet-1.1.11-2.fc25.noarch.rpm arquillian-test-api-1.1.11-2.fc25.noarch.rpm arquillian-test-impl-base-1.1.11-2.fc25.noarch.rpm arquillian-test-parent-1.1.11-2.fc25.noarch.rpm arquillian-test-spi-1.1.11-2.fc25.noarch.rpm arquillian-testenricher-cdi-1.1.11-2.fc25.noarch.rpm arquillian-testenricher-ejb-1.1.11-2.fc25.noarch.rpm arquillian-testenricher-initialcontext-1.1.11-2.fc25.noarch.rpm arquillian-testenricher-parent-1.1.11-2.fc25.noarch.rpm arquillian-testenricher-resource-1.1.11-2.fc25.noarch.rpm arquillian-testng-container-1.1.11-2.fc25.noarch.rpm arquillian-testng-core-1.1.11-2.fc25.noarch.rpm arquillian-testng-parent-1.1.11-2.fc25.noarch.rpm arquillian-testng-standalone-1.1.11-2.fc25.noarch.rpm arquillian-core-javadoc-1.1.11-2.fc25.noarch.rpm arquillian-core-1.1.11-2.fc25.src.rpm arquillian-core-impl-base.noarch: W: no-documentation arquillian-core-parent.noarch: W: no-documentation arquillian-core-spi.noarch: W: no-documentation arquillian-bom.noarch: W: no-documentation arquillian-build.noarch: W: no-documentation arquillian-config-api.noarch: W: no-documentation arquillian-config-impl-base.noarch: W: no-documentation arquillian-config-parent.noarch: W: no-documentation arquillian-config-spi.noarch: W: no-documentation arquillian-container-impl-base.noarch: W: no-documentation arquillian-container-parent.noarch: W: no-documentation arquillian-container-spi.noarch: W: no-documentation arquillian-container-test-api.noarch: W: no-documentation arquillian-container-test-impl-base.noarch: W: no-documentation arquillian-container-test-spi.noarch: W: no-documentation arquillian-junit-container.noarch: W: no-documentation arquillian-junit-core.noarch: W: no-documentation arquillian-junit-parent.noarch: W: no-documentation arquillian-junit-standalone.noarch: W: no-documentation arquillian-parent.noarch: W: no-documentation arquillian-protocol-jmx.noarch: W: no-documentation arquillian-protocol-parent.noarch: W: no-documentation arquillian-protocol-servlet.noarch: W: no-documentation arquillian-test-api.noarch: W: no-documentation arquillian-test-impl-base.noarch: W: no-documentation arquillian-test-parent.noarch: W: no-documentation arquillian-test-spi.noarch: W: no-documentation arquillian-testenricher-cdi.noarch: W: no-documentation arquillian-testenricher-ejb.noarch: W: no-documentation arquillian-testenricher-initialcontext.noarch: W: no-documentation arquillian-testenricher-parent.noarch: W: no-documentation arquillian-testenricher-resource.noarch: W: no-documentation arquillian-testng-container.noarch: W: no-documentation arquillian-testng-core.noarch: W: no-documentation arquillian-testng-parent.noarch: W: no-documentation arquillian-testng-standalone.noarch: W: no-documentation arquillian-core.src:105: W: unversioned-explicit-provides bundled(jboss-common-core) 39 packages and 0 specfiles checked; 0 errors, 37 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory arquillian-core-spi.noarch: W: no-documentation arquillian-junit-standalone.noarch: W: no-documentation arquillian-bom.noarch: W: no-documentation arquillian-core-impl-base.noarch: W: no-documentation arquillian-testenricher-parent.noarch: W: no-documentation arquillian-test-impl-base.noarch: W: no-documentation arquillian-protocol-jmx.noarch: W: no-documentation arquillian-protocol-servlet.noarch: W: no-documentation arquillian-config-api.noarch: W: no-documentation arquillian-junit-container.noarch: W: no-documentation arquillian-testng-core.noarch: W: no-documentation arquillian-junit-parent.noarch: W: no-documentation arquillian-testng-parent.noarch: W: no-documentation arquillian-container-impl-base.noarch: W: no-documentation arquillian-container-parent.noarch: W: no-documentation arquillian-container-test-impl-base.noarch: W: no-documentation arquillian-container-test-spi.noarch: W: no-documentation arquillian-testng-standalone.noarch: W: no-documentation arquillian-junit-core.noarch: W: no-documentation arquillian-core-parent.noarch: W: no-documentation arquillian-test-api.noarch: W: no-documentation arquillian-testenricher-resource.noarch: W: no-documentation arquillian-container-spi.noarch: W: no-documentation arquillian-testenricher-ejb.noarch: W: no-documentation arquillian-testng-container.noarch: W: no-documentation arquillian-testenricher-initialcontext.noarch: W: no-documentation arquillian-container-test-api.noarch: W: no-documentation arquillian-config-impl-base.noarch: W: no-documentation arquillian-test-parent.noarch: W: no-documentation arquillian-config-spi.noarch: W: no-documentation arquillian-testenricher-cdi.noarch: W: no-documentation arquillian-test-spi.noarch: W: no-documentation arquillian-parent.noarch: W: no-documentation arquillian-build.noarch: W: no-documentation arquillian-config-parent.noarch: W: no-documentation arquillian-protocol-parent.noarch: W: no-documentation 38 packages and 0 specfiles checked; 0 errors, 36 warnings. Requires -------- arquillian-core-api (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) arquillian-core-spi (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.core:arquillian-core-api) arquillian-junit-standalone (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.config:arquillian-config-impl-base) mvn(org.jboss.arquillian.core:arquillian-core-impl-base) mvn(org.jboss.arquillian.junit:arquillian-junit-core) mvn(org.jboss.arquillian.test:arquillian-test-impl-base) mvn(org.jboss.arquillian.test:arquillian-test-spi) arquillian-bom (rpmlib, GLIBC filtered): java-headless javapackages-tools arquillian-core-impl-base (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.core:arquillian-core-api) mvn(org.jboss.arquillian.core:arquillian-core-spi) arquillian-testenricher-parent (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian:arquillian-parent:pom:) arquillian-test-impl-base (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.test:arquillian-test-api) mvn(org.jboss.arquillian.test:arquillian-test-spi) arquillian-protocol-jmx (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.container:arquillian-container-test-spi) arquillian-protocol-servlet (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.container:arquillian-container-spi) mvn(org.jboss.arquillian.container:arquillian-container-test-api) mvn(org.jboss.arquillian.container:arquillian-container-test-impl-base) mvn(org.jboss.arquillian.container:arquillian-container-test-spi) mvn(org.jboss.shrinkwrap.descriptors:shrinkwrap-descriptors-spi) arquillian-config-api (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.shrinkwrap.descriptors:shrinkwrap-descriptors-api-base) arquillian-junit-container (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.container:arquillian-container-impl-base) mvn(org.jboss.arquillian.container:arquillian-container-test-api) mvn(org.jboss.arquillian.container:arquillian-container-test-impl-base) mvn(org.jboss.arquillian.container:arquillian-container-test-spi) mvn(org.jboss.arquillian.core:arquillian-core-impl-base) mvn(org.jboss.arquillian.junit:arquillian-junit-core) mvn(org.jboss.arquillian.test:arquillian-test-api) mvn(org.jboss.arquillian.test:arquillian-test-impl-base) mvn(org.jboss.arquillian.test:arquillian-test-spi) mvn(org.jboss.shrinkwrap:shrinkwrap-impl-base) arquillian-testng-core (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.test:arquillian-test-spi) arquillian-junit-parent (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian:arquillian-parent:pom:) arquillian-testng-parent (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian:arquillian-parent:pom:) arquillian-container-impl-base (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.config:arquillian-config-api) mvn(org.jboss.arquillian.config:arquillian-config-impl-base) mvn(org.jboss.arquillian.container:arquillian-container-spi) mvn(org.jboss.arquillian.core:arquillian-core-api) mvn(org.jboss.arquillian.core:arquillian-core-spi) mvn(org.jboss.shrinkwrap.descriptors:shrinkwrap-descriptors-spi) arquillian-container-parent (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian:arquillian-parent:pom:) arquillian-container-test-impl-base (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.container:arquillian-container-spi) mvn(org.jboss.arquillian.container:arquillian-container-test-api) mvn(org.jboss.arquillian.container:arquillian-container-test-spi) mvn(org.jboss.arquillian.test:arquillian-test-api) arquillian-container-test-spi (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.container:arquillian-container-spi) mvn(org.jboss.arquillian.container:arquillian-container-test-api) mvn(org.jboss.arquillian.test:arquillian-test-spi) arquillian-testng-standalone (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.config:arquillian-config-impl-base) mvn(org.jboss.arquillian.core:arquillian-core-impl-base) mvn(org.jboss.arquillian.test:arquillian-test-impl-base) mvn(org.jboss.arquillian.test:arquillian-test-spi) mvn(org.jboss.arquillian.testng:arquillian-testng-core) arquillian-junit-core (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.test:arquillian-test-spi) arquillian-core-parent (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian:arquillian-parent:pom:) arquillian-test-api (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.core:arquillian-core-api) arquillian-testenricher-resource (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.container:arquillian-container-test-spi) mvn(org.jboss.arquillian.test:arquillian-test-spi) arquillian-container-spi (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.config:arquillian-config-api) mvn(org.jboss.arquillian.config:arquillian-config-impl-base) mvn(org.jboss.arquillian.core:arquillian-core-spi) mvn(org.jboss.shrinkwrap.descriptors:shrinkwrap-descriptors-api-base) mvn(org.jboss.shrinkwrap:shrinkwrap-api) arquillian-core-javadoc (rpmlib, GLIBC filtered): javapackages-tools arquillian-testenricher-ejb (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.container:arquillian-container-test-spi) mvn(org.jboss.arquillian.test:arquillian-test-spi) arquillian-testng-container (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.container:arquillian-container-impl-base) mvn(org.jboss.arquillian.container:arquillian-container-test-api) mvn(org.jboss.arquillian.container:arquillian-container-test-impl-base) mvn(org.jboss.arquillian.container:arquillian-container-test-spi) mvn(org.jboss.arquillian.core:arquillian-core-impl-base) mvn(org.jboss.arquillian.test:arquillian-test-api) mvn(org.jboss.arquillian.test:arquillian-test-impl-base) mvn(org.jboss.arquillian.test:arquillian-test-spi) mvn(org.jboss.arquillian.testng:arquillian-testng-core) mvn(org.jboss.shrinkwrap:shrinkwrap-impl-base) arquillian-testenricher-initialcontext (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.container:arquillian-container-test-spi) mvn(org.jboss.arquillian.test:arquillian-test-spi) arquillian-container-test-api (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.shrinkwrap:shrinkwrap-api) arquillian-config-impl-base (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.config:arquillian-config-api) mvn(org.jboss.arquillian.core:arquillian-core-api) mvn(org.jboss.arquillian.core:arquillian-core-spi) mvn(org.jboss.shrinkwrap.descriptors:shrinkwrap-descriptors-spi) arquillian-test-parent (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian:arquillian-parent:pom:) arquillian-config-spi (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) arquillian-testenricher-cdi (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.container:arquillian-container-test-spi) mvn(org.jboss.arquillian.test:arquillian-test-spi) arquillian-test-spi (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian.core:arquillian-core-spi) mvn(org.jboss.arquillian.test:arquillian-test-api) arquillian-parent (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.apache.maven.plugins:maven-jar-plugin) mvn(org.apache.maven.plugins:maven-source-plugin) mvn(org.apache.maven.plugins:maven-surefire-plugin) mvn(org.jboss:jboss-parent:pom:) arquillian-build (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian:arquillian-parent:pom:) arquillian-config-parent (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian:arquillian-parent:pom:) arquillian-protocol-parent (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.sun:tools) mvn(org.jboss.arquillian:arquillian-parent:pom:) Provides -------- arquillian-core-api: arquillian-core-api mvn(org.jboss.arquillian.core:arquillian-core-api) mvn(org.jboss.arquillian.core:arquillian-core-api:pom:) arquillian-core-spi: arquillian-core-spi mvn(org.jboss.arquillian.core:arquillian-core-spi) mvn(org.jboss.arquillian.core:arquillian-core-spi:pom:) arquillian-junit-standalone: arquillian-junit-standalone mvn(org.jboss.arquillian.junit:arquillian-junit-standalone) mvn(org.jboss.arquillian.junit:arquillian-junit-standalone:pom:) arquillian-bom: arquillian-bom mvn(org.jboss.arquillian:arquillian-bom:pom:) arquillian-core-impl-base: arquillian-core-impl-base mvn(org.jboss.arquillian.core:arquillian-core-impl-base) mvn(org.jboss.arquillian.core:arquillian-core-impl-base:pom:) arquillian-testenricher-parent: arquillian-testenricher-parent mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-parent:pom:) arquillian-test-impl-base: arquillian-test-impl-base mvn(org.jboss.arquillian.test:arquillian-test-impl-base) mvn(org.jboss.arquillian.test:arquillian-test-impl-base:pom:) arquillian-protocol-jmx: arquillian-protocol-jmx mvn(org.jboss.arquillian.protocol:arquillian-protocol-jmx) mvn(org.jboss.arquillian.protocol:arquillian-protocol-jmx:pom:) arquillian-protocol-servlet: arquillian-protocol-servlet mvn(org.jboss.arquillian.protocol:arquillian-protocol-servlet) mvn(org.jboss.arquillian.protocol:arquillian-protocol-servlet:pom:) arquillian-config-api: arquillian-config-api mvn(org.jboss.arquillian.config:arquillian-config-api) mvn(org.jboss.arquillian.config:arquillian-config-api:pom:) arquillian-junit-container: arquillian-junit-container mvn(org.jboss.arquillian.junit:arquillian-junit-container) mvn(org.jboss.arquillian.junit:arquillian-junit-container:pom:) arquillian-testng-core: arquillian-testng-core mvn(org.jboss.arquillian.testng:arquillian-testng-core) mvn(org.jboss.arquillian.testng:arquillian-testng-core:pom:) arquillian-junit-parent: arquillian-junit-parent mvn(org.jboss.arquillian.junit:arquillian-junit-parent:pom:) arquillian-testng-parent: arquillian-testng-parent mvn(org.jboss.arquillian.testng:arquillian-testng-parent:pom:) arquillian-container-impl-base: arquillian-container-impl-base mvn(org.jboss.arquillian.container:arquillian-container-impl-base) mvn(org.jboss.arquillian.container:arquillian-container-impl-base:pom:) arquillian-container-parent: arquillian-container-parent mvn(org.jboss.arquillian.container:arquillian-container-parent:pom:) arquillian-container-test-impl-base: arquillian-container-test-impl-base mvn(org.jboss.arquillian.container:arquillian-container-test-impl-base) mvn(org.jboss.arquillian.container:arquillian-container-test-impl-base:pom:) arquillian-container-test-spi: arquillian-container-test-spi mvn(org.jboss.arquillian.container:arquillian-container-test-spi) mvn(org.jboss.arquillian.container:arquillian-container-test-spi:pom:) arquillian-testng-standalone: arquillian-testng-standalone mvn(org.jboss.arquillian.testng:arquillian-testng-standalone) mvn(org.jboss.arquillian.testng:arquillian-testng-standalone:pom:) arquillian-junit-core: arquillian-junit-core mvn(org.jboss.arquillian.junit:arquillian-junit-core) mvn(org.jboss.arquillian.junit:arquillian-junit-core:pom:) arquillian-core-parent: arquillian-core-parent mvn(org.jboss.arquillian.core:arquillian-core-parent:pom:) arquillian-test-api: arquillian-test-api mvn(org.jboss.arquillian.test:arquillian-test-api) mvn(org.jboss.arquillian.test:arquillian-test-api:pom:) arquillian-testenricher-resource: arquillian-testenricher-resource mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-resource) mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-resource:pom:) arquillian-container-spi: arquillian-container-spi mvn(org.jboss.arquillian.container:arquillian-container-spi) mvn(org.jboss.arquillian.container:arquillian-container-spi:pom:) arquillian-core-javadoc: arquillian-core-javadoc arquillian-testenricher-ejb: arquillian-testenricher-ejb mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-ejb) mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-ejb:pom:) arquillian-testng-container: arquillian-testng-container mvn(org.jboss.arquillian.testng:arquillian-testng-container) mvn(org.jboss.arquillian.testng:arquillian-testng-container:pom:) arquillian-testenricher-initialcontext: arquillian-testenricher-initialcontext mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-initialcontext) mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-initialcontext:pom:) arquillian-container-test-api: arquillian-container-test-api mvn(org.jboss.arquillian.container:arquillian-container-test-api) mvn(org.jboss.arquillian.container:arquillian-container-test-api:pom:) arquillian-config-impl-base: arquillian-config-impl-base bundled(jboss-common-core) mvn(org.jboss.arquillian.config:arquillian-config-impl-base) mvn(org.jboss.arquillian.config:arquillian-config-impl-base:pom:) arquillian-test-parent: arquillian-test-parent mvn(org.jboss.arquillian.test:arquillian-test-parent:pom:) arquillian-config-spi: arquillian-config-spi mvn(org.jboss.arquillian.config:arquillian-config-spi) mvn(org.jboss.arquillian.config:arquillian-config-spi:pom:) arquillian-testenricher-cdi: arquillian-testenricher-cdi mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-cdi) mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-cdi:pom:) arquillian-test-spi: arquillian-test-spi mvn(org.jboss.arquillian.test:arquillian-test-spi) mvn(org.jboss.arquillian.test:arquillian-test-spi:pom:) arquillian-parent: arquillian-parent mvn(org.jboss.arquillian:arquillian-parent:pom:) arquillian-build: arquillian-build mvn(org.jboss.arquillian:arquillian-build:pom:) arquillian-config-parent: arquillian-config-parent mvn(org.jboss.arquillian.config:arquillian-config-parent:pom:) arquillian-protocol-parent: arquillian-protocol-parent mvn(org.jboss.arquillian.protocol:arquillian-protocol-parent:pom:) Source checksums ---------------- https://github.com/arquillian/arquillian-core/archive/1.1.11.Final.tar.gz : CHECKSUM(SHA256) this package : 2bff27c08c83451802f18b42ee370dc272bef7fa0a92b421b73327323e2ef558 CHECKSUM(SHA256) upstream package : 2bff27c08c83451802f18b42ee370dc272bef7fa0a92b421b73327323e2ef558 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1316195 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Before I approve the package, I would like to clarify one issue - While the provides and requires look correct, why is this not mentioned in the spec file? ---------------------------------------------------------------------- Also, please contact upstream about license headers for the following files - Unknown or generated -------------------- arquillian-core-1.1.11.Final/build/ide/eclipse/templates/junit/ArquillianJUnitTest.java arquillian-core-1.1.11.Final/build/ide/netbeans/templates/JUnit/ArquillianJUnitTest.java arquillian-core-1.1.11.Final/container/impl-base/src/main/java/org/jboss/arquillian/container/impl/client/deployment/ArchiveDeploymentExporter.java arquillian-core-1.1.11.Final/container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/enricher/resource/RemoteResourceCommand.java arquillian-core-1.1.11.Final/container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/enricher/resource/RemoteResourceCommandObserver.java arquillian-core-1.1.11.Final/core/impl-base/src/main/java/org/jboss/arquillian/core/impl/threading/ThreadedExecutorService.java arquillian-core-1.1.11.Final/core/impl-base/src/test/java/org/jboss/arquillian/core/impl/ThreadedExecutorServiceTestCase.java arquillian-core-1.1.11.Final/core/impl-base/src/test/java/org/jboss/arquillian/core/impl/loadable/util/FakeService.java arquillian-core-1.1.11.Final/core/impl-base/src/test/java/org/jboss/arquillian/core/impl/loadable/util/ShouldBeExcluded.java arquillian-core-1.1.11.Final/core/impl-base/src/test/java/org/jboss/arquillian/core/impl/loadable/util/ShouldBeIncluded.java arquillian-core-1.1.11.Final/javadoc/stylesheet.css arquillian-core-1.1.11.Final/junit/core/src/main/java/org/jboss/arquillian/junit/event/AfterRules.java arquillian-core-1.1.11.Final/junit/core/src/main/java/org/jboss/arquillian/junit/event/BeforeRules.java arquillian-core-1.1.11.Final/junit/core/src/test/java/org/jboss/arquillian/junit/rules/AbstractRuleStatementEnrichment.java arquillian-core-1.1.11.Final/junit/core/src/test/java/org/jboss/arquillian/junit/rules/InnerRuleInnerStatementEnrichment.java arquillian-core-1.1.11.Final/junit/core/src/test/java/org/jboss/arquillian/junit/rules/OuterRuleInnerStatementEnrichment.java arquillian-core-1.1.11.Final/junit/core/src/test/java/org/jboss/arquillian/junit/rules/OuterRuleOuterStatementEnrichment.java arquillian-core-1.1.11.Final/junit/core/src/test/java/org/jboss/arquillian/junit/rules/ResourcesImpl.java arquillian-core-1.1.11.Final/junit/core/src/test/java/org/jboss/arquillian/junit/rules/ResourcesProvider.java arquillian-core-1.1.11.Final/junit/core/src/test/java/org/jboss/arquillian/junit/rules/RulesEnrichmentTestCase.java arquillian-core-1.1.11.Final/junit/core/src/test/java/org/jboss/arquillian/junit/rules/TestingMethodRule.java arquillian-core-1.1.11.Final/junit/core/src/test/java/org/jboss/arquillian/junit/rules/TestingMethodRuleInnerStatement.java arquillian-core-1.1.11.Final/junit/core/src/test/java/org/jboss/arquillian/junit/rules/TestingStatement.java arquillian-core-1.1.11.Final/junit/core/src/test/java/org/jboss/arquillian/junit/rules/TestingTestRule.java arquillian-core-1.1.11.Final/junit/core/src/test/java/org/jboss/arquillian/junit/rules/TestingTestRuleInnerStatement.java arquillian-core-1.1.11.Final/junit/standalone/src/main/java/org/jboss/arquillian/junit/standalone/AllLifecycleEventExecutor.java arquillian-core-1.1.11.Final/protocols/servlet/src/main/java/org/jboss/arquillian/protocol/servlet/arq514hack/descriptors/api/web/WebAppDescriptor.java arquillian-core-1.1.11.Final/testenrichers/cdi/src/main/java/org/jboss/arquillian/testenricher/cdi/container/CDIExtension.java arquillian-core-1.1.11.Final/testenrichers/cdi/src/test/java/org/jboss/arquillian/testenricher/cdi/CDIInjectionEnricherTestCase.java arquillian-core-1.1.11.Final/testenrichers/cdi/src/test/java/org/jboss/arquillian/testenricher/cdi/beans/Cat.java arquillian-core-1.1.11.Final/testenrichers/cdi/src/test/java/org/jboss/arquillian/testenricher/cdi/beans/CatService.java arquillian-core-1.1.11.Final/testenrichers/cdi/src/test/java/org/jboss/arquillian/testenricher/cdi/beans/Dog.java arquillian-core-1.1.11.Final/testenrichers/cdi/src/test/java/org/jboss/arquillian/testenricher/cdi/beans/DogService.java arquillian-core-1.1.11.Final/testenrichers/cdi/src/test/java/org/jboss/arquillian/testenricher/cdi/beans/Service.java arquillian-core-1.1.11.Final/testenrichers/resource/src/test/java/org/jboss/arquillian/testenricher/resource/ResourceInjectionEnricherTestCase.java arquillian-core-1.1.11.Final/testng/container/src/test/java/org/jboss/arquillian/testng/container/ShouldProvideConfigurationFailureToTestRunner.java arquillian-core-1.1.11.Final/testng/container/src/test/java/org/jboss/arquillian/testng/container/ShouldProvideVariousTestResultsToTestRunner.java arquillian-core-1.1.11.Final/testng/core/src/main/java/org/jboss/arquillian/testng/TestDataProviderTransformer.java
(In reply to Mukundan Ragavan from comment #21) > Before I approve the package, I would like to clarify one issue - > > While the provides and requires look correct, why is this not mentioned in > the spec file? > > ---------------------------------------------------------------------- > > > Also, please contact upstream about license headers for the following files Already reported: https://github.com/arquillian/arquillian-core/issues/101
(In reply to gil cattaneo from comment #22) > (In reply to Mukundan Ragavan from comment #21) > > Before I approve the package, I would like to clarify one issue - > > > > While the provides and requires look correct, why is this not mentioned in > > the spec file? Provides and requires are handled by maven-local/javapackages-utils, and it is not necessary to add another
Thanks for the replies. Package APPROVED.
Thanks for the review!
Requested re-integration: https://fedorahosted.org/rel-eng/ticket/6377
Requested re-integration: https://fedorahosted.org/rel-eng/ticket/6382
arquillian-core-1.1.11-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-21d8855ef1
arquillian-core-1.1.11-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3ff7fe15be
arquillian-core-1.1.11-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-21d8855ef1
arquillian-core-1.1.11-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3ff7fe15be
arquillian-core-1.1.11-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
arquillian-core-1.1.11-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.