Bug 1316436

Summary: IFS is not set back after used as "[" in log_newer function of include.rc
Product: [Community] GlusterFS Reporter: Raghavendra Talur <rtalur>
Component: testsAssignee: Raghavendra Talur <rtalur>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.7.9CC: bugs, fanghuang.data, pkarampu
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 3.7.12 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1245425 Environment:
Last Closed: 2016-10-18 11:17:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1245425    
Bug Blocks:    

Description Raghavendra Talur 2016-03-10 09:02:05 UTC 
+++ This bug was initially created as a clone of Bug #1245425 +++

Description of problem:

In log_newer function, IFS is set to "[". It should be set back before the function return. This causes the last cleanup in basic/afr/self-heald.t to create a diretory "/d/backends\ /mnt/glusterfs/0\ /mnt/glusterfs/1\ /mnt/glusterfs/2\ /mnt/nfs/0\ /mnt/nfs/1/".

The following is part of the log file. The bash shell add single quotes to the variable WORKDIRS

+ umount -l /mnt/nfs/1
+ umount -f /mnt/nfs/1
+ true
+ rm -rf '/d/backends /mnt/glusterfs/0 /mnt/glusterfs/1 /mnt/glusterfs/2 /mnt/nfs/0 /mnt/nfs/1'
+ leftover=
+ for d in '$WORKDIRS'
+ test -d '/d/backends /mnt/glusterfs/0 /mnt/glusterfs/1 /mnt/glusterfs/2 /mnt/nfs/0 /mnt/nfs/1'
+ '[' x '!=' x ']'
+ mkdir -p '/d/backends /mnt/glusterfs/0 /mnt/glusterfs/1 /mnt/glusterfs/2 /mnt/nfs/0 /mnt/nfs/1'
+ return 0
+ exit


Version-Release number of selected component (if applicable):

3.7.2

How reproducible:

always

Steps to Reproduce:
1. ./run-tests ./test/basic/afr/self-heald.t
2. ls /d
backends  backends 

Actual results:

Two directories "backends  backends " are shown.

Expected results:

only one "backends" directory exits.

Additional info:

--- Additional comment from Anand Avati on 2015-07-28 19:24:51 IST ---

REVIEW: http://review.gluster.org/11779 (tests: reset IFS after changing it) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2015-07-30 15:29:29 IST ---

REVIEW: http://review.gluster.org/11779 (tests: reset IFS after changing it) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)