Bug 1317916

Summary: `hammer docker registry` command cannot find its proper routes
Product: Red Hat Satellite Reporter: Oleksandr Shtaier <oshtaier>
Component: HammerAssignee: Adam Price <adprice>
Status: CLOSED DUPLICATE QA Contact: Stephen Benjamin <stbenjam>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: bbuckingham, ehelms, omaciel, stbenjam
Target Milestone: UnspecifiedKeywords: PrioBumpQA, Triaged
Target Release: Unused   
Hardware: x86_64   
OS: Linux   
URL: http://projects.theforeman.org/issues/13528
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-31 21:52:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Oleksandr Shtaier 2016-03-15 13:53:13 UTC
Description of problem:
In 6.1 we have:
hammer docker --help
Usage:
    hammer docker [OPTIONS] SUBCOMMAND [ARG] ...

Parameters:
 SUBCOMMAND                    subcommand
 [ARG] ...                     subcommand arguments

Subcommands:
 container                     Manage docker containers
 image                         Manage docker images
 registry                      Manage docker registries
 tag                           Manage docker tags

But in 6.2:
hammer docker --help
Usage:
    hammer docker [OPTIONS] SUBCOMMAND [ARG] ...

Parameters:
 SUBCOMMAND                    subcommand
 [ARG] ...                     subcommand arguments

Subcommands:
 container                     Manage docker containers
 tag                           Manage docker tags

However we have corresponding API paths:
Registries:

GET /docker/api/v2/registries 	        List all docker registries
GET /docker/api/v2/registries/:id 	Show a docker registry
POST /docker/api/v2/registries 	        Create a docker registry
PUT /docker/api/v2/registries/:id 	Update a docker registry
DELETE /docker/api/v2/registries/:id 	Delete a docker registry

And they are working fine, so it seems issue is specific for Hammer

Version-Release number of selected component (if applicable):
6.2 SNAP 3.1

How reproducible:
Always

Steps to Reproduce:
1. Try to create docker registry through CLI

Actual results:
Necessary commands are absent in hammer

Expected results:
Necessary operations with docker can be performed successfully

Additional info:

Comment 2 Oleksandr Shtaier 2016-03-15 14:36:41 UTC
Oops, it seems API requests to registries are also corrupted

Comment 3 Brad Buckingham 2016-03-17 19:12:11 UTC
It appears that we need an updated version of hammer_cli_foreman_docker.  We currently have tfm-rubygem-hammer_cli_foreman_docker-0.0.3-5.el7sat.noarch; however, we need to pick up the changes that were introduced with 0.0.4.  I have added a reference to the redmine issue that introduced those changes.

Comment 4 Stephen Benjamin 2016-03-24 19:02:46 UTC
Failed. Registry command doesn't work.

# hammer -u admin -p changeme docker registry list
404 Resource Not Found


/var/log/foreman/production.log

2016-03-24 15:01:15 [app] [I] Started GET "/docker/api/v2/registries?page=1&per_page=1000" for ::1 at 2016-03-24 15:01:15 -0400
2016-03-24 15:01:15 [app] [F] 
 | ActionController::RoutingError (No route matches [GET] "/docker/api/v2/registries"):



Found in: Satellite 6.2 SNAP 5.1

Comment 5 Bryan Kearney 2016-03-24 20:05:08 UTC
Upstream bug assigned to adprice

Comment 6 Adam Price 2016-03-31 16:57:14 UTC
It appears that this bugzilla has changed from its original filing.

Comment 7 Adam Price 2016-03-31 19:46:39 UTC
this fix [1] is needed in Satellite 6 for the routes to generate properly for `/docker` instead of `/foreman_docker`.

[1] http://projects.theforeman.org/issues/14322

Comment 8 Adam Price 2016-03-31 19:53:37 UTC
foreman_docker-2.0.1 is the latest released version of the gem, but it doesn't contain the changes that fix this issue.

Comment 9 Adam Price 2016-03-31 21:52:02 UTC

*** This bug has been marked as a duplicate of bug 1320338 ***