Bug 1318368

Summary: Review Request: perl-IRI - Internationalized Resource Identifiers
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-IRI-0.004-1.fc25 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-21 15:42:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1321042    

Description Petr Pisar 2016-03-16 16:35:00 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-IRI/perl-IRI.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-IRI/perl-IRI-0.004-1.fc25.src.rpm
Description:
The IRI module provides an object representation for Internationalized
Resource Identifiers (IRIs) as defined by RFC 3987 and supports their
parsing, serializing, and base resolution.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2016-03-18 12:39:27 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-IRI-0.004-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(:VERSION) >= 5.14.0
      1 perl(Data::Dumper)
      1 perl(Moo)
      1 perl(MooX::HandlesVia)
      1 perl(Scalar::Util)
      1 perl(Types::Standard)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-IRI-0.004-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(IRI) = 0.004
      1 perl-IRI = 0.004-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-IRI*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

BuildRequires are ok
FIX: Please add 'coreutils' - specfile line 45
TODO: perl(strict) and perl(warnings) could be part of first group of BR,
      because they are used in Makefile.PL

FIX: Remove '%clean' from spec file line 60


Please correct all 'FIX' issues and consider fixing 'TODO' items.

Otherwise package is good.
Approved
Comment 2 Gwyn Ciesla 2016-03-21 14:01:43 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-IRI
Comment 3 Petr Pisar 2016-03-21 15:42:38 UTC 
Thank you for the review and the repository. I fixes all the issues.