Bug 1318687

Summary: Review Request: perl-XML-NamespaceFactory - Simple factory objects for SAX name-spaced names
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-XML-NamespaceFactory-1.02-1.fc25 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-21 15:57:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1318691    

Description Petr Pisar 2016-03-17 13:59:49 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-XML-NamespaceFactory/perl-XML-NamespaceFactory.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-XML-NamespaceFactory/perl-XML-NamespaceFactory-1.02-1.fc25.src.rpm
Description:
This is a simple object-oriented storage for XML name spaces.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2016-03-21 12:04:22 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-XML-NamespaceFactory-1.02-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(Carp)
      1 perl(overload)
      1 perl(strict)
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-XML-NamespaceFactory-1.02-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(XML::NamespaceFactory) = 1.02
      1 perl(XML::NamespaceFactory::TiedHash)
      1 perl-XML-NamespaceFactory = 1.02-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-XML-NamespaceFactory*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok


FIX: Please add BRs 'findutils', 'make'
The rest of buildrequires are OK.

Please correct 'FIX' issue.

Otherwise the package looks good.
Approved
Comment 2 Gwyn Ciesla 2016-03-21 14:36:42 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-XML-NamespaceFactory
Comment 3 Petr Pisar 2016-03-21 15:57:05 UTC 
Thank you for the review and the repository. I fixed all the issues.