Bug 1318691 - Review Request: perl-XML-CommonNS - List of commonly used XML name spaces
Summary: Review Request: perl-XML-CommonNS - List of commonly used XML name spaces
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1318687
Blocks: 1321042
TreeView+ depends on / blocked
 
Reported: 2016-03-17 14:04 UTC by Petr Pisar
Modified: 2016-03-30 08:00 UTC (History)
2 users (show)

Fixed In Version: perl-XML-CommonNS-0.06-1.fc25
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-03-22 14:19:53 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2016-03-17 14:04:59 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-XML-CommonNS/perl-XML-CommonNS.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-XML-CommonNS/perl-XML-CommonNS-0.06-1.fc25.src.rpm
Description:
This provides definitions of some XML name spaces as strings and
XML::NamespaceFactory objects.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-03-22 09:23:33 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-XML-CommonNS-0.06-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(Exporter)
      1 perl(XML::NamespaceFactory)
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-XML-CommonNS-0.06-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(XML::CommonNS) = 0.06
      1 perl-XML-CommonNS = 0.06-1.fc25
Binary provides are Ok.

$ rpmlint perl-XML-CommonNS*
perl-XML-CommonNS.noarch: W: spelling-error %description -l en_US NamespaceFactory -> Satisfactory
perl-XML-CommonNS.src: W: spelling-error %description -l en_US NamespaceFactory -> Satisfactory
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2016-03-22 13:44:42 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-XML-CommonNS

Comment 3 Petr Pisar 2016-03-22 14:19:53 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.