Bug 1319952

Summary:	Tag Control issues on service dialogue imports between appliances
Product:	Red Hat CloudForms Management Engine	Reporter:	Colin Arnott <carnott>
Component:	Control	Assignee:	eclarizi
Status:	CLOSED CURRENTRELEASE	QA Contact:	Shveta <sshveta>
Severity:	low	Docs Contact:
Priority:	medium
Version:	5.5.0	CC:	benglish, brant.evans, cpelland, jhardy, jprause, obarenbo, simaishi
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.7.0
Hardware:	x86_64
OS:	Linux
Whiteboard:	tag:service:dialog
Fixed In Version:	5.7.0.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1321600 1322830 1346956 (view as bug list)		Environment:
Last Closed:	2017-01-11 19:58:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1321600, 1322830, 1346956

Description Colin Arnott 2016-03-21 23:28:49 UTC

Description of problem:
Exported Service Dialogues with tag control items have the tag category_id statically assigned and can therefore lose their relationship to the tag imported into another appliance if the ID does not match exactly. Having a matching ID is not likely in our environment, even for built-in tags because of region numbers.

Version-Release number of selected component (if applicable):
cfme-5.5.2.4-1.el7cf.x86_64

How reproducible:
trivial

Steps to Reproduce:
1. export a service dialogue
2. import the service dialogue to another appliance

Actual results:
tag control items lose their relationship to the tag imported into another appliance

Expected results:
A better import method would look up tag categories and use an existing category rather than orphaning the tag control in the dialog and requiring it to be re-associated.

Additional info:
talk.manageiq.org thread: http://talk.manageiq.org/t/tag-control-issues-on-service-dialog-imports-between-appliances/1302
github issue: https://github.com/ManageIQ/manageiq/issues/7449

Comment 2 CFME Bot 2016-03-29 15:01:15 UTC

https://github.com/ManageIQ/manageiq/pull/7574

Comment 3 Shveta 2016-04-12 18:30:47 UTC

Not able to reproduce the issue in 5.5.3.4.20160407153134_b3e2a83

Comment 6 CFME Bot 2016-05-02 18:25:37 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/42a9c9bd87c0ce9ae5d3517242a3cce4e2255b87

commit 42a9c9bd87c0ce9ae5d3517242a3cce4e2255b87
Author:     Erik Clarizio <eclarizi>
AuthorDate: Tue Mar 29 07:43:14 2016 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Mon May 2 07:47:07 2016 -0700

    Export category name/description so that imports can utilize them
    
    https://github.com/ManageIQ/manageiq/issues/7449
    https://bugzilla.redhat.com/show_bug.cgi?id=1319952

 app/models/dialog_field_importer.rb         |  7 ++++
 app/models/dialog_field_serializer.rb       |  5 +++
 spec/models/dialog_field_importer_spec.rb   | 51 ++++++++++++++++++++++++++++-
 spec/models/dialog_field_serializer_spec.rb | 32 ++++++++++++++++--
 4 files changed, 92 insertions(+), 3 deletions(-)

Comment 7 CFME Bot 2016-05-02 18:25:41 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/3f892baa0e50996945de1323b924e75ca53ee469

commit 3f892baa0e50996945de1323b924e75ca53ee469
Author:     Erik Clarizio <eclarizi>
AuthorDate: Mon May 2 07:46:27 2016 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Mon May 2 07:47:07 2016 -0700

    Ensure that old import files without a category name will still import
    
    https://github.com/ManageIQ/manageiq/issues/7449
    https://bugzilla.redhat.com/show_bug.cgi?id=1319952

 app/models/dialog_field_importer.rb       | 19 ++++++---
 spec/models/dialog_field_importer_spec.rb | 66 ++++++++++++++++++-------------
 2 files changed, 53 insertions(+), 32 deletions(-)

Comment 8 CFME Bot 2016-05-17 17:23:11 UTC

https://github.com/ManageIQ/manageiq/pull/8473

Comment 9 Greg McCullough 2016-06-10 12:56:03 UTC

*** Bug 1344520 has been marked as a duplicate of this bug. ***

Comment 12 Shveta 2016-12-06 11:55:08 UTC

Working fine in 5.7.0.13-rc3.20161129142908_1d51fd2