Bug 1320112

Opening to track storage review of the fix and proper solution.

+++ This bug was initially created as a clone of Bug #1319721 +++

Description of problem:
Call to getImagesList on host without connected storage pool, but with SD, return {'status': {'message': 'OK', 'code': 0}

Version-Release number of selected component (if applicable):
vdsm-4.17.23.1-0.el7ev.noarch

How reproducible:
Always

Steps to Reproduce:
1. run script
sdUUID = 'SD_UUID'
 cli = vdscli.connect(timeout=60)
 result = cli.getImagesList(sdUUID)
 print(result)
 result = cli.getConnectedStoragePoolsList()
 print(result)
2.
3.

Actual results:
That prints:
 {'status': {'message': 'OK', 'code': 0}, 'imageslist': []}
 {'status': {'message': 'OK', 'code': 0}, 'poollist': []}

Expected results:
result = cli.getImagesList(sdUUID)
print(result)
{'status': {'message': 'list index out of range', 'code': 100}}

Additional info:
the image are available on the NFS share 

[root@alma07 images]# pwd
/rhev/data-center/mnt/10.35.64.11:_vol_RHEV_Virt_alukiano__HE__upgrade/3ac831d6-6124-4b42-a060-f89c64be09a1/images
[root@alma07 images]# ls -l
total 16
drwxr-xr-x. 2 vdsm kvm 4096 17 mar 15.36 4d1915e1-a9f7-4bca-b666-0997adec5ef4
drwxr-xr-x. 2 vdsm kvm 4096 18 mar 00.52 995171f0-1abb-488b-9b18-3e17aad0c3de
drwxr-xr-x. 2 vdsm kvm 4096 20 mar 15.40 9ecd4e5f-bb24-4fd6-8c20-c442425b59b6
drwxr-xr-x. 2 vdsm kvm 4096 18 mar 00.52 b6b637a4-37be-48e9-aacb-e3d4a6be29cc

but VDSM is not reporting them.

--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-03-21 14:12:27 IST ---

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

--- Additional comment from Simone Tiraboschi on 2016-03-21 15:03 IST ---



--- Additional comment from Allon Mureinik on 2016-03-21 15:05:34 IST ---

I don't understand. Isn't this just a duplicate of bug 1274622 ?

--- Additional comment from Simone Tiraboschi on 2016-03-21 15:11:12 IST ---

We can have an additional simple workaround on hosted-engine side (as for https://gerrit.ovirt.org/#/c/54982/ ) but, if possible, I'd prefer to get this properly fixed on VDSM side to prevent any other surprise on other behavior changes.

--- Additional comment from Simone Tiraboschi on 2016-03-21 15:17:04 IST ---

(In reply to Allon Mureinik from comment #3)
> I don't understand. Isn't this just a duplicate of bug 1274622 ?

No, unfortunately it's not: at 1274622 that call was failing with:
 {'status': {'message': 'list index out of range', 'code': 100}}
and we implemented a workaround for that directly globing under /rhev/data-center/mnt/{mnt_point}/{sduuid}/images to directly find the images on the NFS share.

Now it's also worst since VDSM returns 
 {'status': {'message': 'OK', 'code': 0}, 'imageslist': []} (which is wrong since the images are there!) and so our workaround doesn't trigger anymore.
We can add an additional workaround over that but if possible I'd prefer to get it properly fixed.

--- Additional comment from Sandro Bonazzola on 2016-03-21 15:23:08 IST ---

Workaround has been posted here: https://gerrit.ovirt.org/#/c/54982/1

--- Additional comment from Sandro Bonazzola on 2016-03-21 15:31:24 IST ---

Moving this bug to ovirt-hosted-engine-ha since it has been decided to use the workaround instead of a proper fix in vdsm. Allon, please consider to schedule a proper fix for 3.6.5.

--- Additional comment from Allon Mureinik on 2016-03-21 17:25:59 IST ---

(In reply to Sandro Bonazzola from comment #7)
> Moving this bug to ovirt-hosted-engine-ha since it has been decided to use
> the workaround instead of a proper fix in vdsm. Allon, please consider to
> schedule a proper fix for 3.6.5.
Please clone it to track that initiative, although, atm, I can't commit to such a fix.