Bug 1320821

Summary:	volume set on user.* domain trims all white spaces in the value
Product:	[Community] GlusterFS	Reporter:	Atin Mukherjee <amukherj>
Component:	glusterd	Assignee:	Atin Mukherjee <amukherj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.9	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.10	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1316499	Environment:
Last Closed:	2016-04-19 07:00:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1316499
Bug Blocks:

Description Atin Mukherjee 2016-03-24 04:31:25 UTC

+++ This bug was initially created as a clone of Bug #1316499 +++

Description of problem:
On executing gluster volume set <volname> user.metadata "abc xyz" gluster volume info shows user.metadata as "abcxyz"

Version-Release number of selected component (if applicable):
mainline

How reproducible:
Always


Actual results:
user.metadata as "abcxyz"

Expected results:
user.metadata as "abc xyz"

--- Additional comment from Vijay Bellur on 2016-03-10 06:17:12 EST ---

REVIEW: http://review.gluster.org/13669 (cli: Do not remove whitespace if key is user.* in volume set) posted (#1) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Vijay Bellur on 2016-03-24 00:10:14 EDT ---

COMMIT: http://review.gluster.org/13669 committed in master by Kaushal M (kaushal) 
------
commit f2d51d6546976731fed5fd165bf57acac3fb0180
Author: Atin Mukherjee <amukherj>
Date:   Thu Mar 10 16:43:08 2016 +0530

    cli: Do not remove whitespace if key is user.* in volume set
    
    setting any user.* option can have multiple words in the key and hence skip the
    process of trimming whitespaces.
    
    Change-Id: Ia295428d7cda55e5470fef668325bea497f2333d
    BUG: 1316499
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/13669
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Kaushal M <kaushal>

Comment 1 Vijay Bellur 2016-03-24 04:32:08 UTC

REVIEW: http://review.gluster.org/13821 (cli: Do not remove whitespace if key is user.* in volume set) posted (#1) for review on release-3.7 by Atin Mukherjee (amukherj)

Comment 2 Vijay Bellur 2016-03-24 09:23:36 UTC

COMMIT: http://review.gluster.org/13821 committed in release-3.7 by Atin Mukherjee (amukherj) 
------
commit 75046f96c40679da8dae20a3a0b2f6a2b4c34517
Author: Atin Mukherjee <amukherj>
Date:   Thu Mar 10 16:43:08 2016 +0530

    cli: Do not remove whitespace if key is user.* in volume set
    
    Backport of http://review.gluster.org/#/c/13669
    
    setting any user.* option can have multiple words in the key and hence skip the
    process of trimming whitespaces.
    
    Change-Id: Ia295428d7cda55e5470fef668325bea497f2333d
    BUG: 1320821
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/13669
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Kaushal M <kaushal>
    Reviewed-on: http://review.gluster.org/13821

Comment 3 Kaushal 2016-04-19 07:00:49 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.10, please open a new bug report.

glusterfs-3.7.10 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-April/026164.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user