| Summary: | Review Request: python-units - Python support for quantities with units | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fschwarz, package-review, zbyszek |
| Target Milestone: | --- | Keywords: | EasyFix |
| Target Release: | --- | Flags: | zbyszek:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-04-19 20:31:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Igor Gnatenko
2016-03-29 08:46:12 UTC
+ name is OK
+ license is OK (PSF)
+ license file is present, %license is used
+ python packaging macros are used
+ provides/requires look sane
+ %python_provide is used
+ no scriptlets present or necessary
+ builds and install OK
Package is APPROVED.
Comments:
I'd add:
%global _description \
Provides support for quantities and units, ...
%description %_description
%description -n python2-%{modname} %_description
%description -n python3-%{modname} %_description
I don't think deleting tests is proper. Quite often you want to run the tests on the target system.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-units python-units-0.06-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f0c42bf1c8 python-units-0.06-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f0c42bf1c8 python-units-0.06-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |