Bug 1322521

Summary:	Choose self-heal source as local subvolume if possible
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.10	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.10	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1314150	Environment:
Last Closed:	2016-04-19 07:01:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1314150
Bug Blocks:

Description Pranith Kumar K 2016-03-30 15:54:07 UTC

+++ This bug was initially created as a clone of Bug #1314150 +++

Description of problem:
Choose self-heal source as local brick improves network bandwidth usage tremendously. This is very useful for 3-way replication with hyperconverged usecase.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-03-02 23:37:11 EST ---

REVIEW: http://review.gluster.org/13585 (cluster/afr: Choose local child as source if possible) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Vijay Bellur on 2016-03-06 22:42:32 EST ---

REVIEW: http://review.gluster.org/13585 (cluster/afr: Choose local child as source if possible) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Vijay Bellur on 2016-03-11 03:57:20 EST ---

REVIEW: http://review.gluster.org/13585 (cluster/afr: Choose local child as source if possible) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Vijay Bellur on 2016-03-11 14:15:03 EST ---

COMMIT: http://review.gluster.org/13585 committed in master by Jeff Darcy (jdarcy) 
------
commit 2807e3fc005630213ab7ad251fef13d61c07ac6b
Author: Pranith Kumar K <pkarampu>
Date:   Wed Mar 2 22:09:44 2016 +0530

    cluster/afr: Choose local child as source if possible
    
    It is better to choose local brick as source if possible to prevent
    over the wire read thus saving on bandwidth. Also changed code to not
    attempt data-heal if 'source' is selected as arbiter.
    
    Change-Id: I9a328d0198422280b13a30ab99545370a301dfea
    BUG: 1314150
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/13585
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Tested-by: Krutika Dhananjay <kdhananj>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

--- Additional comment from Mike McCune on 2016-03-28 18:23:05 EDT ---

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 1 Vijay Bellur 2016-03-30 15:55:14 UTC

REVIEW: http://review.gluster.org/13860 (cluster/afr: Choose local child as source if possible) posted (#1) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu)

Comment 2 Vijay Bellur 2016-03-31 06:31:01 UTC

COMMIT: http://review.gluster.org/13860 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit c0d9bb7828fcecb3cba27ed8708c69c90a13e07d
Author: Pranith Kumar K <pkarampu>
Date:   Wed Mar 2 22:09:44 2016 +0530

    cluster/afr: Choose local child as source if possible
    
    It is better to choose local brick as source if possible to prevent
    over the wire read thus saving on bandwidth. Also changed code to not
    attempt data-heal if 'source' is selected as arbiter.
    
     >Change-Id: I9a328d0198422280b13a30ab99545370a301dfea
     >BUG: 1314150
     >Signed-off-by: Pranith Kumar K <pkarampu>
     >Reviewed-on: http://review.gluster.org/13585
     >Smoke: Gluster Build System <jenkins.com>
     >NetBSD-regression: NetBSD Build System <jenkins.org>
     >Reviewed-by: Krutika Dhananjay <kdhananj>
     >Tested-by: Krutika Dhananjay <kdhananj>
     >CentOS-regression: Gluster Build System <jenkins.com>
     >Reviewed-by: Jeff Darcy <jdarcy>
     >(cherry picked from commit 2807e3fc005630213ab7ad251fef13d61c07ac6b)
    
    Change-Id: I24ea66683f81e238a6c1850664a49fe554011a0a
    BUG: 1322521
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/13860
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Ravishankar N <ravishankar>

Comment 3 Kaushal 2016-04-19 07:01:21 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.10, please open a new bug report.

glusterfs-3.7.10 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-April/026164.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user