Bug 1322523

Summary:	Fd based fops should not be logging ENOENT/ESTALE
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	protocol	Assignee:	Pranith Kumar K <pkarampu>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.10	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1315168	Environment:
Last Closed:	2016-06-28 12:13:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1315168
Bug Blocks:

Description Pranith Kumar K 2016-03-30 15:56:38 UTC

+++ This bug was initially created as a clone of Bug #1315168 +++

Description of problem:
Ideally fd based operations shouldn't be logging ENOENT/ESTALE. But it can happen when self-heal is yet to happen where the files need to be re-created etc.
So don't log them as ERRORS

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-03-07 02:10:00 EST ---

REVIEW: http://review.gluster.org/13621 (protocol/server: Do not log ENOENT in readv) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Vijay Bellur on 2016-03-07 02:19:45 EST ---

REVIEW: http://review.gluster.org/13621 (protocol/server: Do not log ENOENT/ESTALE in fd based fops) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Vijay Bellur on 2016-03-15 11:27:21 EDT ---

COMMIT: http://review.gluster.org/13621 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit b145cd15ded130078c9f1105e76f35d0886e62d5
Author: Pranith Kumar K <pkarampu>
Date:   Mon Mar 7 11:52:18 2016 +0530

    protocol/server: Do not log ENOENT/ESTALE in fd based fops
    
    When fd-fops come on anon-fds there is a chance to log ENOENT/ESTALE for them.
    Log it as DEBUG.
    
    Change-Id: I8ae53c29d6a66f6a65081c281a9a5c205f53766b
    BUG: 1315168
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/13621
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Ashish Pandey <aspandey>
    Reviewed-by: Jeff Darcy <jdarcy>
    Smoke: Gluster Build System <jenkins.com>

Comment 1 Vijay Bellur 2016-04-27 11:16:45 UTC

REVIEW: http://review.gluster.org/14091 (protocol/server: Do not log ENOENT/ESTALE in fd based fops) posted (#1) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu)

Comment 2 Vijay Bellur 2016-05-03 06:51:20 UTC

COMMIT: http://review.gluster.org/14091 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit a71f7923c1c6bc929c93e9179e243011a9da6209
Author: Pranith Kumar K <pkarampu>
Date:   Mon Mar 7 11:52:18 2016 +0530

    protocol/server: Do not log ENOENT/ESTALE in fd based fops
    
    When fd-fops come on anon-fds there is a chance to log ENOENT/ESTALE for them.
    Log it as DEBUG.
    
     >Change-Id: I8ae53c29d6a66f6a65081c281a9a5c205f53766b
     >BUG: 1315168
     >Signed-off-by: Pranith Kumar K <pkarampu>
     >Reviewed-on: http://review.gluster.org/13621
     >CentOS-regression: Gluster Build System <jenkins.com>
     >NetBSD-regression: NetBSD Build System <jenkins.org>
     >Reviewed-by: Ashish Pandey <aspandey>
     >Reviewed-by: Jeff Darcy <jdarcy>
     >Smoke: Gluster Build System <jenkins.com>
    
    BUG: 1322523
    Change-Id: I4265bcb7dbdd70c3d0c7550434f743675313edf7
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/14091
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 3 Kaushal 2016-06-28 12:13:55 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report.

glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user