Bug 1326505

Summary:	fuse: fix inode and dentry leaks
Product:	Red Hat Gluster Storage	Reporter:	Shyamsundar <srangana>
Component:	fuse	Assignee:	Shyamsundar <srangana>
Status:	CLOSED ERRATA	QA Contact:	Nag Pavan Chilakam <nchilaka>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rhgs-3.1	CC:	asrivast, chrisw, csaba, nlevinki, pkarampu, rcyriac, rhinduja, sankarshan
Target Milestone:	---	Keywords:	ZStream
Target Release:	RHGS 3.1.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.9-2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-23 05:17:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1311817

Description Shyamsundar 2016-04-12 20:35:18 UTC

Description of problem:
When a readdirp was executed, the nlookup count for each inode of the returned entries was incremented. However the kernel does not increment the counter for '.' and '..' entries.

This caused kernel to send forgets with a counter smaller than the inode's current value. This prevented these inodes to be retired when ref count was 0.

This behavior needs fixing.

Comment 6 Nag Pavan Chilakam 2016-05-09 08:38:57 UTC

Discussed with Dev. and found that there  is no clear  way of validating this bug as this is a code change with no direct functional impact.
However moving it to verified as discussed with differnt stakeholders
However, following was what i did test:
tried to check the lookups using profiling and didn't find difference b/w fuse client versions of 3.7.9-1(before fix) and 3.7.9-3(after fix) (the server versions for both were common 3.7.9-3) However dev. mentioned that this may not be right test

Did a lot of IO and checked statedump before clearing client cache and after clearing client cache( searched for IO the hot-count in inode table ) didnt see much difference b/w the different client version 

However I didnt see any impact on IOs or any regressions and hence positive of this fix

Comment 8 errata-xmlrpc 2016-06-23 05:17:17 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1240