Bug 1326505 - fuse: fix inode and dentry leaks
Summary: fuse: fix inode and dentry leaks
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: fuse
Version: rhgs-3.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: RHGS 3.1.3
Assignee: Shyamsundar
QA Contact: Nag Pavan Chilakam
URL:
Whiteboard:
Depends On:
Blocks: 1311817
TreeView+ depends on / blocked
 
Reported: 2016-04-12 20:35 UTC by Shyamsundar
Modified: 2016-06-23 05:17 UTC (History)
8 users (show)

Fixed In Version: glusterfs-3.7.9-2
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-23 05:17:17 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1240 0 normal SHIPPED_LIVE Red Hat Gluster Storage 3.1 Update 3 2016-06-23 08:51:28 UTC

Description Shyamsundar 2016-04-12 20:35:18 UTC
Description of problem:
When a readdirp was executed, the nlookup count for each inode of the returned entries was incremented. However the kernel does not increment the counter for '.' and '..' entries.

This caused kernel to send forgets with a counter smaller than the inode's current value. This prevented these inodes to be retired when ref count was 0.

This behavior needs fixing.

Comment 6 Nag Pavan Chilakam 2016-05-09 08:38:57 UTC
Discussed with Dev. and found that there  is no clear  way of validating this bug as this is a code change with no direct functional impact.
However moving it to verified as discussed with differnt stakeholders
However, following was what i did test:
tried to check the lookups using profiling and didn't find difference b/w fuse client versions of 3.7.9-1(before fix) and 3.7.9-3(after fix) (the server versions for both were common 3.7.9-3) However dev. mentioned that this may not be right test

Did a lot of IO and checked statedump before clearing client cache and after clearing client cache( searched for IO the hot-count in inode table ) didnt see much difference b/w the different client version 

However I didnt see any impact on IOs or any regressions and hence positive of this fix

Comment 8 errata-xmlrpc 2016-06-23 05:17:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1240


Note You need to log in before you can comment on or make changes to this bug.