Bug 1326513

Summary: CSS overflow detection algorithms perform badly, are really slow
Product: [oVirt] ovirt-engine Reporter: Greg Sheremeta <gshereme>
Component: Frontend.WebAdminAssignee: Greg Sheremeta <gshereme>
Status: CLOSED CURRENTRELEASE QA Contact: Petr Matyáš <pmatyas>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.0.0CC: bugs, mlehrer, oourfali, tnisan
Target Milestone: ovirt-4.1.0-alphaKeywords: Performance
Target Release: 4.1.0Flags: rule-engine: ovirt-4.1+
rule-engine: planning_ack+
tnisan: devel_ack+
pnovotny: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-01 14:43:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: UX RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Greg Sheremeta 2016-04-12 20:59:44 UTC 
Description of problem:
CSS overflow detection algorithm performs badly, are really slow

Version-Release number of selected component (if applicable):
4.0, 3.6

How reproducible:
always

Steps to Reproduce:
using a JavaScript profiler and a draft-compiled engine, you can see that a lot of time is spent in org.ovirt.engine.ui.common.utils.ElementUtils::detectOverflowUsingScrollWidth and detectOverflowUsingClientHeight

Actual results:
bad performance

Expected results:
better performance

Additional info:
These algorithms are used to detect when to truncate text in grid cells. They are used heavily, so they need to perform better.
Comment 1 Sandro Bonazzola 2016-05-02 09:56:33 UTC 
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.
Comment 2 Yaniv Lavi 2016-05-23 13:17:52 UTC 
oVirt 4.0 beta has been released, moving to RC milestone.
Comment 3 Yaniv Lavi 2016-05-23 13:24:28 UTC 
oVirt 4.0 beta has been released, moving to RC milestone.
Comment 4 Sandro Bonazzola 2016-12-12 14:01:54 UTC 
The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.
Comment 5 Petr Matyáš 2017-01-23 11:16:37 UTC 
Verified on rhv-4.1.0-8