Bug 1326513 - CSS overflow detection algorithms perform badly, are really slow
Summary: CSS overflow detection algorithms perform badly, are really slow
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.1.0-alpha
: 4.1.0
Assignee: Greg Sheremeta
QA Contact: Petr Matyáš
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-12 20:59 UTC by Greg Sheremeta
Modified: 2017-02-01 14:43 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:43:01 UTC
oVirt Team: UX
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: planning_ack+
tnisan: devel_ack+
pnovotny: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 56719 0 master MERGED webadmin: speed up text truncation detection 2016-06-15 14:49:00 UTC

Description Greg Sheremeta 2016-04-12 20:59:44 UTC
Description of problem:
CSS overflow detection algorithm performs badly, are really slow

Version-Release number of selected component (if applicable):
4.0, 3.6

How reproducible:
always

Steps to Reproduce:
using a JavaScript profiler and a draft-compiled engine, you can see that a lot of time is spent in org.ovirt.engine.ui.common.utils.ElementUtils::detectOverflowUsingScrollWidth and detectOverflowUsingClientHeight

Actual results:
bad performance

Expected results:
better performance

Additional info:
These algorithms are used to detect when to truncate text in grid cells. They are used heavily, so they need to perform better.

Comment 1 Sandro Bonazzola 2016-05-02 09:56:33 UTC
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.

Comment 2 Yaniv Lavi 2016-05-23 13:17:52 UTC
oVirt 4.0 beta has been released, moving to RC milestone.

Comment 3 Yaniv Lavi 2016-05-23 13:24:28 UTC
oVirt 4.0 beta has been released, moving to RC milestone.

Comment 4 Sandro Bonazzola 2016-12-12 14:01:54 UTC
The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.

Comment 5 Petr Matyáš 2017-01-23 11:16:37 UTC
Verified on rhv-4.1.0-8


Note You need to log in before you can comment on or make changes to this bug.