Bug 1326586
Summary: | Review request: Sensu | ||
---|---|---|---|
Product: | [Community] RDO | Reporter: | Martin Magr <mmagr> |
Component: | Package Review | Assignee: | hguemar |
Status: | CLOSED WONTFIX | QA Contact: | hguemar |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | trunk | CC: | apevec, chris.brown, mmagr, mrunge |
Target Milestone: | --- | ||
Target Release: | trunk | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-08-18 19:21:36 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1290163 |
Description
Martin Magr
2016-04-13 07:41:25 UTC
I'd drop the Group tag in all of them, it's completely unused for a while. Found some bizarre things. e.g: Dude, where's my running test suite? https://github.com/opstools-packages/rubygem-sensu-plugin/blob/master/rubygem-sensu-plugin.spec#L55 e.g: use of versioned %fcX macro instead of %fedora one https://github.com/opstools-packages/rubygem-amq-protocol/blob/master/rubygem-amq-protocol.spec#L21 Since Opstools won't be part of the RDO, but in the separate SIG, I guess this review is not needed anymore, am I correct? (In reply to Martin Magr from comment #2) > Since Opstools won't be part of the RDO, but in the separate SIG, I guess > this review is not needed anymore, am I correct? No, we still need a review. Martin, do you still need this open? I would ideally love to see this reviewed :). There has been an version update on this package since then. Should I update this BZ or do you want me to create new review request instead? I'm not clear, I guess Matthias will be able to say. Christopher, a review is still highly appreciated. Martin, please update this ticket here for the updated version. There is no need in creating a new review request, unless you'd want to separate all the packages into single review requests. |