RDO tickets are now tracked in Jira https://issues.redhat.com/projects/RDO/issues/
Bug 1326586 - Review request: Sensu
Summary: Review request: Sensu
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: RDO
Classification: Community
Component: Package Review
Version: trunk
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: trunk
Assignee: hguemar
QA Contact: hguemar
URL:
Whiteboard:
Depends On:
Blocks: RDO-MITAKA, RDO-MITAKA-REVIEWS
TreeView+ depends on / blocked
 
Reported: 2016-04-13 07:41 UTC by Martin Magr
Modified: 2020-08-18 19:21 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-18 19:21:36 UTC
Embargoed:


Attachments (Terms of Use)

Description Martin Magr 2016-04-13 07:41:25 UTC
=== Main package ===

== sensu ==
Spec URL: https://github.com/opstools-packages/sensu/blob/master/sensu.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/sensu/0.22.0/1.el7/src/sensu-0.22.0-1.el7.src.rpm
Description: A monitoring framework


=== dependencies ==

== rubygem-async_sinatra ==
Spec URL: https://github.com/opstools-packages/rubygem-async_sinatra/blob/master/rubygem-async_sinatra.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-async_sinatra/1.2.0/1.el7/src/rubygem-async_sinatra-1.2.0-1.el7.src.rpm
Description: A Sinatra plugin to provide convenience whilst performing asynchronous responses inside of the Sinatra framework running under async webservers. To properly utilise this package, some knowledge of EventMachine and/or asynchronous patterns is recommended. Currently, supporting servers include: * Thin * Rainbows * Zbatery.

== rubygem-em-redis-unified ==
Spec URL: https://github.com/opstools-packages/rubygem-em-redis-unified/blob/master/rubygem-em-redis-unified.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-em-redis-unified/1.0.1/1.el7/src/rubygem-em-redis-unified-1.0.1-1.el7.src.rpm
Description: An eventmachine-based implementation of the Redis protocol

== rubygem-eventmachine ==
Spec URL: https://github.com/opstools-packages/rubygem-eventmachine/blob/master/rubygem-eventmachine.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-eventmachine/1.0.8/2.el7/src/rubygem-eventmachine-1.0.8-2.el7.src.rpm
Description: EventMachine implements a fast, single-threaded engine for arbitrary network communications. It's extremely easy to use in Ruby. EventMachine wraps all interactions with IP sockets, allowing programs to concentrate on the implementation of network protocols. It can be used to create both network servers and clients. To create a server or client, a Ruby program only needs to specify the IP address and port, and provide a Module that implements the communications protocol. Implementations of several standard network protocols are provided with the package, primarily to serve as examples. The real goal of EventMachine is to enable programs to easily interface with other programs using TCP/IP, especially if custom protocols are required.

== rubygem-multi_json ==
Spec URL: https://github.com/opstools-packages/rubygem-multi_json/blob/master/rubygem-multi_json.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-multi_json/1.11.2/1.el7/src/rubygem-multi_json-1.11.2-1.el7.src.rpm
Description: A common interface to multiple JSON libraries, including Oj, Yajl, the JSON gem (with C-extensions), the pure-Ruby JSON gem, NSJSONSerialization, gson.rb, JrJackson, and OkJson.

== rubygem-sensu-extension ==
Spec URL: https://github.com/opstools-packages/rubygem-sensu-extension/blob/master/rubygem-sensu-extension.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-sensu-extension/1.3.0/1.el7/src/rubygem-sensu-extension-1.3.0-1.el7.src.rpm
Description: The Sensu extension library.

== rubygem-sensu-extensions ==
Spec URL: https://github.com/opstools-packages/rubygem-sensu-extensions/blob/master/rubygem-sensu-extensions.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-sensu-extensions/1.4.0/1.el7/src/rubygem-sensu-extensions-1.4.0-1.el7.src.rpm
Description: The Sensu extension loader library.

== rubygem-sensu-logger ==
Spec URL: https://github.com/opstools-packages/rubygem-sensu-logger/blob/master/rubygem-sensu-logger.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-sensu-logger/1.1.0/1.el7/src/rubygem-sensu-logger-1.1.0-1.el7.src.rpm
Description: The Sensu logger library.

== rubygem-sensu-settings ==
Spec URL: https://github.com/opstools-packages/rubygem-sensu-settings/blob/master/rubygem-sensu-settings.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-sensu-settings/3.3.0/1.el7/src/rubygem-sensu-settings-3.3.0-1.el7.src.rpm
Description: The Sensu settings library, loader and validator.

== rubygem-sensu-spawn ==
Spec URL: https://github.com/opstools-packages/rubygem-sensu-spawn/blob/master/rubygem-sensu-spawn.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-sensu-spawn/1.6.0/1.el7/src/rubygem-sensu-spawn-1.6.0-1.el7.src.rpm
Description: The Sensu spawn process library.

== rubygem-sensu-transport ==
Spec URL: https://github.com/opstools-packages/rubygem-sensu-transport/blob/master/rubygem-sensu-transport.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-sensu-transport/3.3.0/1.el7/src/rubygem-sensu-transport-3.3.0-1.el7.src.rpm
Description:

== rubygem-sinatra ==
Spec URL: https://github.com/opstools-packages/rubygem-sinatra/blob/master/rubygem-sinatra.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-sinatra/1.4.6/1.el7/src/rubygem-sinatra-1.4.6-1.el7.src.rpm
Description: Sinatra is a DSL intended for quickly creating web-applications in Ruby with minimal effort.

== rubygem-thin ==
Spec URL: https://github.com/opstools-packages/rubygem-thin/blob/master/rubygem-thin.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-thin/1.6.3/1.el7/src/rubygem-thin-1.6.3-1.el7.src.rpm
Description: Thin is a Ruby web server that glues together three of the best Ruby libraries in web history. The Mongrel parser, the root of Mongrel speed and security, Event Machine, a network I/O library with extremely high scalability and Rack, a minimal interface between webservers and Ruby frameworks.

== rubygem-uuidtools ==
Spec URL: https://github.com/opstools-packages/rubygem-uuidtools/blob/master/rubygem-uuidtools.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-uuidtools/2.1.5/2.el7/src/rubygem-uuidtools-2.1.5-2.el7.src.rpm
Description: UUIDTools was designed to be a simple library for generating any of the various types of UUIDs. It conforms to RFC 4122 whenever possible.

== rubygem-amqp ==
Spec URL: https://github.com/opstools-packages/rubygem-amqp/blob/master/rubygem-amqp.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-amqp/1.5.0/2.el7/src/rubygem-amqp-1.5.0-2.el7.src.rpm
Description: Widely used, feature-rich asynchronous RabbitMQ client with batteries included.

== rubygem-amq-protocol ==
Spec URL: https://github.com/opstools-packages/rubygem-amq-protocol/blob/master/rubygem-amq-protocol.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-amq-protocol/1.9.2/3.el7/src/rubygem-amq-protocol-1.9.2-3.el7.src.rpm
Description: amq-protocol is an AMQP 0.9.1 serialization library for Ruby. It is not an AMQP client: amq-protocol only handles serialization and deserialization. If you want to write your own AMQP client, this gem can help you with that.

== rubygem-childprocess ==
Spec URL: https://github.com/opstools-packages/rubygem-childprocess/blob/master/rubygem-childprocess.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-childprocess/0.5.8/1.el7/src/rubygem-childprocess-0.5.8-1.el7.src.rpm
Description: This gem aims at being a simple and reliable solution for controlling external programs running in the background on any Ruby / OS combination.

== rubygem-daemons ==
Spec URL: https://github.com/opstools-packages/rubygem-daemons/blob/master/rubygem-daemons.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-daemons/1.1.9/3.el7/src/rubygem-daemons-1.1.9-3.el7.src.rpm
Description: Daemons provides an easy way to wrap existing ruby scripts (for example a self-written server) to be run as a daemon and to be controlled by simple start/stop/restart commands. You can also call blocks as daemons and control them from the parent or just daemonize the current process. Besides this basic functionality, daemons offers many advanced features like exception backtracing and logging (in case your ruby script crashes) and monitoring and automatic restarting of your processes if they crash.

== rubygem-em-worker ==
Spec URL: https://github.com/opstools-packages/rubygem-em-worker/blob/master/rubygem-em-worker.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-em-worker/0.0.2/2.el7/src/rubygem-em-worker-0.0.2-2.el7.src.rpm
Description: Provides a simple task worker, with a task concurrency limit.

== rubygem-ffi ==
Spec URL: https://github.com/opstools-packages/rubygem-ffi/blob/master/rubygem-ffi.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-ffi/1.9.3/1.el7/src/rubygem-ffi-1.9.3-1.el7.src.rpm
Description: Ruby-FFI is a ruby extension for programmatically loading dynamic libraries, binding functions within them, and calling those functions from Ruby code. Moreover, a Ruby-FFI extension works without changes on Ruby and JRuby. Discover why should you write your next extension using Ruby-FFI here[http://wiki.github.com/ffi/ffi/why-use-ffi].

== rubygem-minitest ==
Spec URL: https://github.com/opstools-packages/rubygem-minitest/blob/master/rubygem-minitest.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-minitest/4.7.0/2.el7/src/rubygem-minitest-4.7.0-2.el7.src.rpm
Description: minitest/unit is a small and fast replacement for ruby's huge and slow test/unit. This is meant to be clean and easy to use both as a regular test writer and for language implementors that need a minimal set of methods to bootstrap a working unit test suite. miniunit/spec is a functionally complete spec engine. miniunit/mock, by Steven Baker, is a beautifully tiny mock object framework.

== rubygem-rack ==
Spec URL: https://github.com/opstools-packages/rubygem-rack/blob/master/rubygem-rack.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-rack/1.5.2/4.el7/src/rubygem-rack-1.5.2-4.el7.src.rpm
Description: Rack provides a common API for connecting web frameworks, web servers and layers of software in between.

== rubygem-rack-protection ==
Spec URL: https://github.com/opstools-packages/rubygem-rack-protection/blob/master/rubygem-rack-protection.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-rack-protection/1.5.3/2.el7/src/rubygem-rack-protection-1.5.3-2.el7.src.rpm
Description: This gem protects against typical web attacks. Should work for all Rack apps, including Rails.

== rubygem-rack-test ==
Spec URL: https://github.com/opstools-packages/rubygem-rack-test/blob/master/rubygem-rack-test.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-rack-test/0.6.2/6.el7/src/rubygem-rack-test-0.6.2-6.el7.src.rpm
Description: Rack::Test is a small, simple testing API for Rack apps. It can be used on its own or as a reusable starting point for Web frameworks and testing libraries to build on. Most of its initial functionality is an extraction of Merb 1.0's request helpers feature.

== rubygem-rspec ==
Spec URL: https://github.com/opstools-packages/rubygem-rspec/blob/master/rubygem-rspec.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-rspec/2.14.1/1.el7/src/rubygem-rspec-2.14.1-1.el7.src.rpm
Description: RSpec is a behaviour driven development (BDD) framework for Ruby.

== rubygem-sensu-em ==
Spec URL: https://github.com/opstools-packages/rubygem-sensu-em/blob/master/rubygem-sensu-em.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-sensu-em/2.4.0/1.el7/src/rubygem-sensu-em-2.4.0-1.el7.src.rpm
Description: EventMachine implements a fast, single-threaded engine for arbitrary network communications. It's extremely easy to use in Ruby. EventMachine wraps all interactions with IP sockets, allowing programs to concentrate on the implementation of network protocols. It can be used to create both network servers and clients. To create a server or client, a Ruby program only needs to specify the IP address and port, and provide a Module that implements the communications protocol. Implementations of several standard network protocols are provided with the package, primarily to serve as examples. The real goal of EventMachine is to enable programs to easily interface with other programs using TCP/IP, especially if custom protocols are required.

== rubygem-sensu-plugin ==
Spec URL: https://github.com/opstools-packages/rubygem-sensu-plugin/blob/master/rubygem-sensu-plugin.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-sensu-plugin/1.2.0/1.el7/src/rubygem-sensu-plugin-1.2.0-1.el7.src.rpm
Description: Plugins and helper libraries for Sensu, a monitoring framework.

== rubygem-test-unit ==
Spec URL: https://github.com/opstools-packages/rubygem-test-unit/blob/master/rubygem-test-unit.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-test-unit/2.5.5/1.el7/src/rubygem-test-unit-2.5.5-1.el7.src.rpm
Description: Test::Unit 2.x - Improved version of Test::Unit bundled in Ruby 1.8.x. Ruby 1.9.x bundles minitest not Test::Unit. Test::Unit bundled in Ruby 1.8.x had not been improved but unbundled Test::Unit (Test::Unit 2.x) will be improved actively.

== rubygem-tilt ==
Spec URL: https://github.com/opstools-packages/rubygem-tilt/blob/master/rubygem-tilt.spec
SRPM URL: http://cbs.centos.org/kojifiles/packages/rubygem-tilt/1.4.1/3.el7/src/rubygem-tilt-1.4.1-3.el7.src.rpm
Description: Generic interface to multiple Ruby template engines.

Comment 1 hguemar 2016-04-13 08:45:19 UTC
I'd drop the Group tag in all of them, it's completely unused for a while.

Found some bizarre things.
e.g: Dude, where's my running test suite? 
https://github.com/opstools-packages/rubygem-sensu-plugin/blob/master/rubygem-sensu-plugin.spec#L55

e.g: use of versioned %fcX macro instead of %fedora one
https://github.com/opstools-packages/rubygem-amq-protocol/blob/master/rubygem-amq-protocol.spec#L21

Comment 2 Martin Magr 2016-08-23 08:47:38 UTC
Since Opstools won't be part of the RDO, but in the separate SIG, I guess this review is not needed anymore, am I correct?

Comment 3 Matthias Runge 2016-08-24 10:41:51 UTC
(In reply to Martin Magr from comment #2)
> Since Opstools won't be part of the RDO, but in the separate SIG, I guess
> this review is not needed anymore, am I correct?

No, we still need a review.

Comment 4 Christopher Brown 2017-06-18 12:22:46 UTC
Martin, do you still need this open?

Comment 5 Martin Magr 2017-06-19 09:07:56 UTC
I would ideally love to see this reviewed :). There has been an version update on this package since then. Should I update this BZ or do you want me to create new review request instead?

Comment 6 Christopher Brown 2017-06-19 10:49:12 UTC
I'm not clear, I guess Matthias will be able to say.

Comment 7 Matthias Runge 2017-06-19 12:23:15 UTC
Christopher, a review is still highly appreciated.

Martin, please update this ticket here for the updated version. There is no need in creating a new review request, unless you'd want to separate all the packages into single review requests.


Note You need to log in before you can comment on or make changes to this bug.