Bug 1326866

Summary: Setting an empty VM Note in VMware does not clear the VM | Container | Notes field
Product: Red Hat CloudForms Management Engine Reporter: Josh Carter <jocarter>
Component: ProvidersAssignee: Adam Grare <agrare>
Status: CLOSED ERRATA QA Contact: Alex Newman <anewman>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.5.0CC: jfrey, jhardy, mfeifer, obarenbo, simaishi
Target Milestone: GA   
Target Release: 5.6.0   
Hardware: All   
OS: All   
Whiteboard: vmware
Fixed In Version: 5.6.0.5 Doc Type: Bug Fix
Doc Text:
Previously, setting an empty note did not clear the text from the Annotations field on a VMware virtual machine when the provider is refreshed. This happened because CloudForms did not correctly parse the empty field. This has been fixed in the code by setting hardware[:annotation] to nil if the config.annotation property is blank. As a result, CloudForms now interprets an empty Annotations field as expected.
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-29 15:49:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 3 CFME Bot 2016-04-25 22:00:52 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/2386d0ab5379a3b20cb1d7b3225032a45bb97efe

commit 2386d0ab5379a3b20cb1d7b3225032a45bb97efe
Author:     Adam Grare <agrare>
AuthorDate: Thu Apr 21 11:09:46 2016 -0400
Commit:     Adam Grare <agrare>
CommitDate: Thu Apr 21 11:47:21 2016 -0400

    Empty VM Notes doesn't clear container notes field
    
    When you clear the VM Notes field of a VM instead of setting
    hardware[:annotation] to nil we leave it unset so it the value
    in the database isn't cleared out.  To fix this set the
    hardware[:annotation] field to nil explicitly if the
    config.annotation property is blank.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1326866

 .../providers/vmware/infra_manager/refresh_parser.rb       |  2 +-
 .../providers/vmware/infra_manager/refresh_parser_spec.rb  | 14 ++++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

Comment 4 Alex Newman 2016-05-13 19:16:22 UTC
5.6.0.6-beta2.5.20160511140943_ff75fb2

Comment 7 errata-xmlrpc 2016-06-29 15:49:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348