Bug 1326866 – Setting an empty VM Note in VMware does not clear the VM | Container | Notes field

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1326866 - Setting an empty VM Note in VMware does not clear the VM | Container | Notes field

Summary:	Setting an empty VM Note in VMware does not clear the VM \| Container \| Notes ...

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat CloudForms Management Engine
Classification:	Red Hat
Component:	Providers (Show other bugs)
Sub Component:
Version:	5.5.0
Hardware:	All All

Priority	medium Severity medium
Target Milestone:	GA
Target Release:	5.6.0
Assigned To:	Adam Grare
QA Contact:	Alex Newman
Docs Contact:

URL:
Whiteboard:	vmware
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2016-04-13 11:02 EDT by Josh Carter
Modified:	2018-01-19 16:28 EST (History)
CC List:	5 users (show)

See Also:
Fixed In Version:	5.6.0.5
Doc Type:	Bug Fix
Doc Text:	Previously, setting an empty note did not clear the text from the Annotations field on a VMware virtual machine when the provider is refreshed. This happened because CloudForms did not correctly parse the empty field. This has been fixed in the code by setting hardware[:annotation] to nil if the config.annotation property is blank. As a result, CloudForms now interprets an empty Annotations field as expected.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2016-06-29 11:49:06 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2016:1348	normal	SHIPPED_LIVE	CFME 5.6.0 bug fixes and enhancement update	2016-06-29 14:50:04 EDT

Groups: None (edit)

Comment 2 CFME Bot 2016-04-21 11:56:07 EDT

https://github.com/ManageIQ/manageiq/pull/8155

Comment 3 CFME Bot 2016-04-25 18:00:52 EDT

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/2386d0ab5379a3b20cb1d7b3225032a45bb97efe

commit 2386d0ab5379a3b20cb1d7b3225032a45bb97efe
Author:     Adam Grare <agrare@redhat.com>
AuthorDate: Thu Apr 21 11:09:46 2016 -0400
Commit:     Adam Grare <agrare@redhat.com>
CommitDate: Thu Apr 21 11:47:21 2016 -0400

    Empty VM Notes doesn't clear container notes field
    
    When you clear the VM Notes field of a VM instead of setting
    hardware[:annotation] to nil we leave it unset so it the value
    in the database isn't cleared out.  To fix this set the
    hardware[:annotation] field to nil explicitly if the
    config.annotation property is blank.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1326866

 .../providers/vmware/infra_manager/refresh_parser.rb       |  2 +-
 .../providers/vmware/infra_manager/refresh_parser_spec.rb  | 14 ++++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

Comment 4 Alex Newman 2016-05-13 15:16:22 EDT

5.6.0.6-beta2.5.20160511140943_ff75fb2

Comment 5 CFME Bot 2016-05-17 13:18:32 EDT

https://github.com/ManageIQ/manageiq/pull/8473

Comment 7 errata-xmlrpc 2016-06-29 11:49:06 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348

Note You need to log in before you can comment on or make changes to this bug.