Bug 1327133

Summary: Cloud Openstack provider requires AMQP hostname to be added
Product: Red Hat CloudForms Management Engine Reporter: Aziza Karol <akarol>
Component: UI - OPSAssignee: Aparna Karve <akarve>
Status: CLOSED ERRATA QA Contact: Aziza Karol <akarol>
Severity: high Docs Contact:
Priority: high    
Version: 5.6.0CC: akarol, cpelland, dajohnso, dclarizi, gblomqui, hkataria, jhardy, jkrocil, lsmola, mpovolny, obarenbo, simaishi
Target Milestone: GA   
Target Release: 5.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ui:provider:openstack
Fixed In Version: 5.6.0.6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-29 15:49:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Aziza Karol 2016-04-14 10:22:12 UTC
Description of problem:


Version-Release number of selected component (if applicable):
5.6.0.1-beta2.20160413141124_e25ac0e 

How reproducible:
100%

Steps to Reproduce:
1.Navigate to cloud providers
2.Add OpenStack cloud provider
3.

Actual results:
Unable to add OpenStack provider. add button disabled 

Expected results:
Add button should be enabled

Additional info:

Comment 2 Jan Krocil 2016-04-14 12:44:36 UTC
AMQP hostname should not be required, it should be optional in case the user doesn't care about AMQP (events).

Comment 3 Dave Johnson 2016-04-14 15:26:35 UTC
In terms of events, I believe we do require events.

The issue is there is no feedback to the customer showing them that they need to fill in AMQP credentials.  We need to highlight the amqp tab or something.

I assume if AMQP creds are not giving, we should try to use the defaults?  For instance, we have a single entry point osp provider, its going to be the same credentials.  Maybe we give feedback, and provide a checkbox that says use default creds.

Comment 4 Harpreet Kataria 2016-04-14 21:10:59 UTC
Aparna,

As discussed, Can you add a note next to hostname field, stating that AMQP hostname field is required.

Thanks,
~Harpreet

Comment 5 Harpreet Kataria 2016-04-14 21:12:13 UTC
Dave,

Can you open an RFE to address changes suggested by you above, as that will require some work to get those changes in.

Thanks,
~Harpreet

Comment 6 Greg Blomquist 2016-04-15 17:51:48 UTC
Harpreet, Aparna,

I was gonna have Ladislav, Marek (OSP Team), and Sam (also OSP team) take a look at this.

I'll assign to Ladislav for now.  He can coordinate with Marek and Sam.

Comment 8 Ladislav Smola 2016-04-18 13:06:27 UTC
I am changing the AMQP hostname as not required, since not filling it up will use Ceilometer events. We have should create yet another RFE to put there radio  button for choosing between AMQP/Ceilometer events

Comment 9 CFME Bot 2016-04-18 14:55:40 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/4d15be6d0a835b40fb3040102e3cb695938a6ab7

commit 4d15be6d0a835b40fb3040102e3cb695938a6ab7
Author:     Ladislav Smola <lsmola>
AuthorDate: Mon Apr 18 11:34:10 2016 +0200
Commit:     Ladislav Smola <lsmola>
CommitDate: Mon Apr 18 11:34:10 2016 +0200

    OpenStack cloud doesn't require AMQP hostname
    
    OpenStack cloud doesn't require AMQP hostname
    
    Fixes BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1327133

 app/views/layouts/angular-bootstrap/_endpoints_angular.html.haml | 1 -
 1 file changed, 1 deletion(-)

Comment 10 Greg Blomquist 2016-04-20 21:32:33 UTC
Ladas / Aparna,

looks like Ladas removed the requirement for the AMQP hostname field.

One idea for allowing the user to select the correct event collector system could be:

* Change the label on the tab to "Events"
* Add a radio button to the "Events" tab allowing the user to select "Ceilometer" or "AMQP"
  - If "AMQP" is selected, the AMQP fields (hostname, port, username password) appear and hostname is required (all others are optional)
  - If "Ceilometer" is selected, the AMQP fields disappear and none are required
* When the form is submitted, 
  - If "AMQP" is selected, an :amqp endpoint is created for the provider with the details from the form
  - If "Ceilometer" is selected, a :ceilometer endpoint is created which is basically empty

On the back end, the event monitor can determine based on the Event endpoint type (or, it's called "role" in the endpoints table) what type of event monitor piece to create.

Thoughts?

Comment 12 Dave Johnson 2016-04-25 20:27:11 UTC
Please open a RFE combining comment 3 and comment 10 into one enhancement request

Comment 13 Aziza Karol 2016-04-26 15:52:57 UTC
Created an RFE https://bugzilla.redhat.com/show_bug.cgi?id=1330635.

Comment 14 Ladislav Smola 2016-05-03 15:34:10 UTC
it should be fixed by this https://github.com/ManageIQ/manageiq/pull/8313

Comment 15 Aziza Karol 2016-05-27 05:29:21 UTC
Able to add OpenStack cloud Providers.

New tab events Added to Openstack providers.Events takes either a Ceilometer or AMQP selection from the user via a radio button.The eventing is set to be ceilometer by default.


Verified:
5.6.0.8-rc1.20160524155303_f2a5a50

Comment 17 errata-xmlrpc 2016-06-29 15:49:22 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348