Bug 1327577

Summary: 'address' node under 'hostdev' node should accept 'type' attribute
Product: [Community] Virtualization Tools Reporter: Zeeshan Ali <zeenix>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED WONTFIX QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: berrange, cfergeau, crobinso, mclasen, mkletzan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-08-18 14:02:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Zeeshan Ali 2016-04-15 12:41:05 UTC
While all address nodes (representing hardware addresses) used throughout libvirt XML accept a 'type' attribute on it, seems it's not the case for 'hostdev' node. This means we'll have to add a work around in libvirt-glib where we have a class hierarchy to represent all these address nodes in a generic way.

So it would be nice if libvirt accepted 'type' attribute on hostdev nodes too, even if it completely ignores it.

Comment 1 Cole Robinson 2016-04-15 13:32:25 UTC
mkletzan do your latest nodedev patches impact this?

Comment 2 Martin Kletzander 2016-04-15 15:05:40 UTC
No, that shouldn't be the case at all.

Comment 4 Daniel Berrangé 2021-08-18 14:02:28 UTC
Any 'type' on the <address> element for a <hostdev> would be redundant, as the format of <hostdev> child elements already discriminates based on the "type" attribute on the <hostdev> element at the top level.