While all address nodes (representing hardware addresses) used throughout libvirt XML accept a 'type' attribute on it, seems it's not the case for 'hostdev' node. This means we'll have to add a work around in libvirt-glib where we have a class hierarchy to represent all these address nodes in a generic way. So it would be nice if libvirt accepted 'type' attribute on hostdev nodes too, even if it completely ignores it.
mkletzan do your latest nodedev patches impact this?
No, that shouldn't be the case at all.
Any 'type' on the <address> element for a <hostdev> would be redundant, as the format of <hostdev> child elements already discriminates based on the "type" attribute on the <hostdev> element at the top level.