Bug 1327734

Summary: Translation bug in file-roller
Product: [Fedora] Fedora Reporter: Jeremy Newton <alexjnewt>
Component: file-rollerAssignee: Matthias Clasen <mclasen>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 23CC: bugzilla.i.sekler, mclasen
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-28 17:20:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1284665    

Description Jeremy Newton 2016-04-15 18:32:40 UTC
Description of problem:
Update breaks translation for some language (french tested, german was noted by someone else)

Version-Release number of selected component (if applicable):
3.16.5-1.fc23 (currently in f23 testing)

Additional info:
This is fixed upstream:
https://bugzilla.gnome.org/show_bug.cgi?id=764342

Also, see comments in bodhi:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-feb00cca4b

Comment 1 Ilja Sekler 2016-04-18 23:05:53 UTC
For some obscure reason the same fixed file-roller-3.16.5-2.fc23.src.rpm with the patch https://git.gnome.org/browse/file-roller/patch/?id=60ef92b66fec1ba86736fbe0df1db5b0a28a2d63 that builds flawlessly on my F23 system fails in copr with a

Makefile:504: *** missing separator.  Stop.

error (which is not quite helpful without access to the said Makefile), so something must be wrong either with the patch or with copr. Given that the official file-roller-3.16.5-1.fc23.src.rpm builds successfully, the former is more likely, unfortunately.

This was my very first attempt to use copr, though.

Comment 2 Ilja Sekler 2016-04-25 21:34:44 UTC
It turns out to be (<http://pkgs.fedoraproject.org/cgit/rpms/file-roller.git/commit/?h=f23&id=b86800c6e24a1be1d998e3eda0632354fdd7e36b>) that the build failure in copr should have been attributed to a missing build dependency on yelp-tools. 

This is absolutely awesome that these issues got fixed on the f23 branch, thanks a lot. I'll give karma as soon as file-roller-3.16.5-2.fc23 reaches the mirrors.

Comment 3 Jeremy Newton 2016-04-28 17:20:47 UTC
Closing as it seems to be fixed in the "file-roller-3.16.5-2" update, currently in testing:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-feb00cca4b

Comment 4 Ilja Sekler 2016-04-28 19:14:05 UTC
"WORKSFORME" is not a correct resolution for this bug because the code change which fixed the issue (<http://pkgs.fedoraproject.org/cgit/rpms/file-roller.git/commit/?h=f23&id=5a1e947e08093cb88f89810fee1b9d0ab85da658>) is known. Would you change it to "ERRATA" please?

https://fedoraproject.org/wiki/BugZappers/BugStatusWorkFlow

Comment 5 Jeremy Newton 2016-04-28 19:16:29 UTC
My bad, misclick. Thanks for catching this!