Bug 132779

Summary:	smb.conf should use sendfile=no by default
Product:	[Fedora] Fedora	Reporter:	Zack Cerza <zcerza>
Component:	samba	Assignee:	Jay Fenlason <fenlason>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jfeeney, rdieter
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-04-07 15:09:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	123268, 136451

Description Zack Cerza 2004-09-16 21:42:01 UTC

The fact that samba's sendfile causes problems isn't new to you. I
propose that 'use sendfile=no' be put in [global] by default.

Comment 1 Steve French 2004-10-05 21:46:35 UTC

samba 3.0.x code already sets sendfile off (no matter what smb.conf 
says) for clients prior to NT4 and when the local tcp sendfile API 
return ENOSYS and when smb signing is enabled.  This should cover all 
of the obvious reasons why samba should not attempt sendfile.

Are there known problems with the tcp sendfile API in particular 
versions of the kernel itself?

I don't know if the ltp or other tests include a simple functional 
test for sendfile but that sounds like an obvious next step.

Comment 2 Jay Fenlason 2005-04-07 15:09:27 UTC

More recent versions of Samba have defaulted to "use sendfile = no" unless 
explicitly overridden in the smb.conf file.  Since we don't set it in the 
default smb.conf, we're set.