| Summary: | RFE: use "Recommends: /usr/bin/vi" instead of hard Requires, so removing 'vim-minimal' does not remove sudo | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Diftraku <diftraku> | ||||||||
| Component: | sudo | Assignee: | Radovan Sroka <rsroka> | ||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | rawhide | CC: | kzak, mattdm, moshima.web, ppisar, rsroka | ||||||||
| Target Milestone: | --- | Keywords: | Reopened, Triaged | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | x86_64 | ||||||||||
| OS: | Linux | ||||||||||
| URL: | https://ghostbin.com/paste/hbasv | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2021-10-03 20:21:19 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Attachments: |
|
||||||||||
|
Description
Diftraku
2016-04-20 18:58:05 UTC
Created attachment 1149168 [details]
Output from 'dnf remove vim-minimal'
This may be a dupe of #164982. Granted, it was closed and did not appear in the guided bug report form. a more recent bugzilla is bug 979382. This isn't a bug in vim, sudo needs to require something like a virtual requirement 'editor' and all editors like nano, ed, emacs, vi, vim need to provide that so that installing either one of them would be sufficient. To make visudo work with those other editors it needs to be compiled with --with-env-editor and the EDITOR variable needs to be set. This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. Even vim-minimal is not completely tiny, and with the advent of /etc/sudoers.d/, editing the config file is rarely necessary. Can we change Requires to Recommends? Created attachment 1333632 [details]
Select default editor at build time
I can see it has already been changed from Requires to Recommends.
I offer here another patch that actually allows to select the default editor at build time. This is needed for Modular Fedora where Platform module does not provide vim-minimal. It provides nano instead.
Simply defining sudo_editor at build time does the trick:
%sudo_editor nano
If you don't have objections, I will apply it into master dist-git branch.
It looks like `editor` in /etc/sudoers takes a list (defaulting to /bin/vi.) I don't have any particular objection, but perhaps we should set that variable to something like: Defaults editor = /usr/bin/vim:/usr/bin/vi:/usr/bin/nano ? I sure would prefer defaulting to vim rather than just vi when available! Yes, I know about the list. The configure option also accepts a list. I only thought the spec intentionally uses single value for whatever (performance, security) reason. I agree that setting a list is better. What about Recommends? Do you want to keep it there? Or recommend vim-enhanced and suggest all the others? I'm not sure what will be the policy about soft dependencies on packages from another modules. I think it's acceptable to Recommend vim-enhanced even if it is not in Platform. Although some releng'a and QE'a scripts performing repoclosure could trigger a wanrnig/error about it. I'm not sure how to handle it. I honestly have no idea. :) Created attachment 1334263 [details]
Define list of default editors starting with vim
This implements the idea of trying vim, vi and as last nano.
So I forgot about this but came across it again. I suppose now we should make it: Defaults editor = /usr/bin/nano:/usr/bin/vim:/usr/bin/vi with nano first, since nano is now our default editor -- and, correspondingly, "Recommends" nano and "Suggests" the others? in Rawhide now (with nano) |