Bug 1329790

Hrm, using the proposed patch,
https://git.reviewboard.kde.org/r/126833
seems to fail the same way

(In reply to Rex Dieter from comment #0)
> kf5-libkface-16.04.0 build fails pretty early on...
> 
> -- First try at finding OpenCV...
> CMake Error at /usr/lib64/OpenCV/OpenCVConfig.cmake:232 (message):
>   opencv_contrib is required but was not found

we have opencv-contrib-3.1.0-2.fc25 , may need be a 
BuildRequires:opencv-contrib, looking to kf5-libkface.spec seems to me that is missing ...

Why does opencv-devel not pull it in already ?

Looks like opencv3 doesn't have a
/usr/lib64/libopencv_contrib.so

like opencv(2) had, so the opencv3 patch may need more work.

(In reply to Rex Dieter from comment #3)
> Why does opencv-devel not pull it in already ?

Should pull it ? 

opencv still not in mirrors I still can't use dnf repoquery to make some checks ...

I can tell from opencv.spec:

%package        devel
Summary:        Development files for using the OpenCV library
Group:          Development/Libraries
Requires:       opencv%{_isa} = %{version}-%{release}


-devel only depends on the main package currently.

It probably needs (at least):
Requires: %{name}-core{_isa} = %{version}-%{release}
Requires: %{name}-contrib%{_isa} = %{version}-%{release}

too.

Interestingly, the main package also has

Requires:       opencv-core%{_isa} = %{version}-%{release}

So, strictly speaking, only the added -contrib is needed

http://answers.opencv.org/question/93533/libopencv_contribso-with-opencv-31/?answer=93543#post-id-93543

we already built as opencv_contrib readme says ...

opencv-3.1.0-3 updated in rawhide :

- Enable build with Qt5.
- VTK support is disabled. Incompatible combination: OpenCV + Qt5 and VTK ver.6.2.0 + Qt4

Created attachment 1150322 [details]
this fix build for me - by default opencv 3 is not used

Sorry, silly me for not noticing that simple cmake flag.

A little further, then fails a new way:

/builddir/build/BUILD/libkface-16.04.0/src/recognition-opencv-lbph/facerec_borrowed.cpp: In static member function 'static cv::Ptr<KFaceIface::LBPHFaceRecognizer> KFaceIface::LBPHFaceRecognizer::create(int, int, int, int, double, KFaceIface::LBPHFaceRecognizer::PredictionStatistics)':
/builddir/build/BUILD/libkface-16.04.0/src/recognition-opencv-lbph/facerec_borrowed.cpp:516:115: error: invalid new-expression of abstract class type 'KFaceIface::LBPHFaceRecognizer'
     LBPHFaceRecognizer* const fr = new LBPHFaceRecognizer(radius, neighbors, grid_x, grid_y, threshold, statistics);
                                                                                                                   ^
In file included from /builddir/build/BUILD/libkface-16.04.0/src/recognition-opencv-lbph/facerec_borrowed.cpp:39:0:
/builddir/build/BUILD/libkface-16.04.0/src/recognition-opencv-lbph/facerec_borrowed.h:51:7: note:   because the following virtual functions are pure within 'KFaceIface::LBPHFaceRecognizer':
 class LBPHFaceRecognizer : public cv::face::FaceRecognizer

This is strange, because I can build it in mock and copr too.

https://copr.fedorainfracloud.org/coprs/sergiomb/opencv/build/180502/

at least for x86_64

https://copr.fedorainfracloud.org/coprs/sergiomb/opencv/build/180554/ There is better link for a build.

any update on this?

incorporating opencv-3.1-support.patch now,
http://koji.fedoraproject.org/koji/taskinfo?taskID=13834727

I'll assume it'll work.

Silly me, I'd only previously tried this patch *or* -DENABLE_OPENCV3=ON, but not both

great job, thanks a lot!