| Summary: | Review Request: libraqm - Complex Textlayout Library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mosaab Alzoubi <moceap> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fahad.alsaidi, khaledhosny, package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-05-02 18:53:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1329817 | ||
|
Description
Mosaab Alzoubi
2016-04-23 11:33:58 UTC
raqm.src: E: description-line-too-long C Library that encapsulates the logic for complex text layout and provide a convenient API. Also "provides" not "provide". raqm-devel.x86_64: W: no-dependency-on raqm/raqm-libs/libraqm raqm-devel.x86_64: E: non-devel-file-in-devel-package /usr/lib64/libraqm.so.0.0.0 raqm-devel.x86_64: E: library-without-ldconfig-postin /usr/lib64/libraqm.so.0.0.0 raqm-devel.x86_64: E: library-without-ldconfig-postun /usr/lib64/libraqm.so.0.0.0 → .so should be in -devel, .so.* in the main package. %license should be used for the license file. No %check? Upstream README says that there are unit tests. Spec URL: http://pastebin.com/raw/q8Ycfukd SRPM URL: https://copr-be.cloud.fedoraproject.org/results/moceap/Raqm/fedora-23-x86_64/00180558-raqm/raqm-0.1.0-2.fc23.src.rpm Everything's OK -devel must require specific version: raqm%{?_isa} = %{version}-%{release}
Wouldn't it be better to call this package libraqm? Upstream uses both "libraqm" and "raqm" in various places. That's the package name in arch linux, and consistency with other distributions is useful for users. Also it's a library, so "lib" prefix is helpful.
Spec URL: http://pastebin.com/raw/AXqVRH7a SRPM URL: https://copr-be.cloud.fedoraproject.org/results/moceap/Raqm/fedora-rawhide-x86_64/00180750-libraqm/libraqm-0.1.0-3.fc25.src.rpm Yes libraqm's better, no applications in main package (pure lib) + license is OK + package name is OK + license file is present, %license is used + scriptlets look sane + provides/requires look sane (one exception below) Package is APPROVED. - main package should not have a dependency (Requires) on -devel. VERY THANK YOU FOR FAST RESPONDING :) Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libraqm libraqm-0.1.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-31501b1f76 libraqm-0.1.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f49283081a libraqm-0.1.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-de4bc206ba libraqm-0.1.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7987fa6183 libraqm-0.1.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f49283081a libraqm-0.1.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-31501b1f76 libraqm-0.1.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-de4bc206ba libraqm-0.1.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7987fa6183 libraqm-0.1.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. libraqm-0.1.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. libraqm-0.1.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. libraqm-0.1.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |