Bug 1329807 - Review Request: libraqm - Complex Textlayout Library
Summary: Review Request: libraqm - Complex Textlayout Library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1329817
TreeView+ depends on / blocked
 
Reported: 2016-04-23 11:33 UTC by Mosaab Alzoubi
Modified: 2016-05-20 20:19 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-02 18:53:10 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Mosaab Alzoubi 2016-04-23 11:33:58 UTC
Spec URL: http://pastebin.com/raw/hWvn0dk7
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/moceap/Raqm/fedora-24-x86_64/00180085-raqm/raqm-0.1.0-1.fc24.src.rpm
Description: Complex Textlayout Library
Fedora Account System Username: moceap

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-04-24 00:42:16 UTC
raqm.src: E: description-line-too-long C Library that encapsulates the logic for complex text layout and provide a convenient API.

Also "provides" not "provide".

raqm-devel.x86_64: W: no-dependency-on raqm/raqm-libs/libraqm

raqm-devel.x86_64: E: non-devel-file-in-devel-package /usr/lib64/libraqm.so.0.0.0
raqm-devel.x86_64: E: library-without-ldconfig-postin /usr/lib64/libraqm.so.0.0.0
raqm-devel.x86_64: E: library-without-ldconfig-postun /usr/lib64/libraqm.so.0.0.0
→ .so should be in -devel, .so.* in the main package.

%license should be used for the license file.

No %check? Upstream README says that there are unit tests.

Comment 3 Zbigniew Jędrzejewski-Szmek 2016-04-26 02:21:55 UTC
-devel must require specific version: raqm%{?_isa} = %{version}-%{release}

Wouldn't it be better to call this package libraqm? Upstream uses both "libraqm" and "raqm" in various places. That's the package name in arch linux, and consistency with other distributions is useful for users. Also it's a library, so "lib" prefix is helpful.

Comment 4 Mosaab Alzoubi 2016-04-26 11:26:45 UTC
Spec URL: http://pastebin.com/raw/AXqVRH7a
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/moceap/Raqm/fedora-rawhide-x86_64/00180750-libraqm/libraqm-0.1.0-3.fc25.src.rpm

Yes libraqm's better, no applications in main package (pure lib)

Comment 5 Zbigniew Jędrzejewski-Szmek 2016-04-26 12:35:24 UTC
+ license is OK
+ package name is OK
+ license file is present, %license is used
+ scriptlets look sane
+ provides/requires look sane (one exception below)

Package is APPROVED.

- main package should not have a dependency (Requires) on -devel.

Comment 6 Mosaab Alzoubi 2016-04-28 10:50:34 UTC
VERY THANK YOU FOR FAST RESPONDING :)

Comment 7 Gwyn Ciesla 2016-04-28 12:40:04 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libraqm

Comment 8 Fedora Update System 2016-05-01 16:10:36 UTC
libraqm-0.1.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-31501b1f76

Comment 9 Fedora Update System 2016-05-01 16:10:43 UTC
libraqm-0.1.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f49283081a

Comment 10 Fedora Update System 2016-05-01 16:10:48 UTC
libraqm-0.1.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-de4bc206ba

Comment 11 Fedora Update System 2016-05-01 16:10:52 UTC
libraqm-0.1.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7987fa6183

Comment 12 Fedora Update System 2016-05-01 17:54:23 UTC
libraqm-0.1.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f49283081a

Comment 13 Fedora Update System 2016-05-02 00:21:32 UTC
libraqm-0.1.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-31501b1f76

Comment 14 Fedora Update System 2016-05-02 00:52:32 UTC
libraqm-0.1.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-de4bc206ba

Comment 15 Fedora Update System 2016-05-02 00:53:23 UTC
libraqm-0.1.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7987fa6183

Comment 16 Fedora Update System 2016-05-02 18:53:05 UTC
libraqm-0.1.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2016-05-07 11:43:56 UTC
libraqm-0.1.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2016-05-10 17:52:36 UTC
libraqm-0.1.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2016-05-20 20:19:34 UTC
libraqm-0.1.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.