Bug 1331860

Summary: Wrong constant used in length based comparison for XATTR_SECURITY_PREFIX
Product: [Community] GlusterFS Reporter: Peter Portante <pportant>
Component: coreAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: mainlineCC: amukherj, bugs, ndevos, pkarampu
Target Milestone: ---Keywords: EasyFix, Triaged
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: glusterfs-3.9.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1335282 (view as bug list) Environment:
Last Closed: 2017-03-27 18:10:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1335282    

Description Peter Portante 2016-04-29 20:41:12 UTC
In libglusterfs/src/syscall.c, line 353, shouldn't XATTR_SECURITY_PREFIX_LEN be used instead of XATTR_TRUSTED_PREFIX_LEN?

https://github.com/gluster/glusterfs/blob/30b66ef3750ece0fb56e673afaca7948d53511e1/libglusterfs/src/syscall.c#L353

Comment 1 Atin Mukherjee 2016-04-30 06:51:45 UTC
This doesn't fall into glusterd. Changing the component to core.

Comment 2 Vijay Bellur 2016-05-04 05:23:48 UTC
REVIEW: http://review.gluster.org/14194 (libglusterfs: Fix security prefix comparison) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 3 Vijay Bellur 2016-05-04 11:28:32 UTC
COMMIT: http://review.gluster.org/14194 committed in master by Jeff Darcy (jdarcy) 
------
commit 7d431c14bc458e9451e9c737f5879968a7b6a0b9
Author: Pranith Kumar K <pkarampu>
Date:   Wed May 4 10:19:23 2016 +0530

    libglusterfs: Fix security prefix comparison
    
    BUG: 1331860
    Change-Id: If35012ee35104848d7d3b21900c7f533d0253cde
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/14194
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 4 Shyamsundar 2017-03-27 18:10:35 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/