Bug 1335282 - Wrong constant used in length based comparison for XATTR_SECURITY_PREFIX
Summary: Wrong constant used in length based comparison for XATTR_SECURITY_PREFIX
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: 3.8.0
Hardware: All
OS: All
unspecified
medium
Target Milestone: ---
Assignee: Pranith Kumar K
QA Contact:
URL:
Whiteboard:
Depends On: 1331860
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-11 18:42 UTC by Pranith Kumar K
Modified: 2016-06-16 14:06 UTC (History)
5 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of: 1331860
Environment:
Last Closed: 2016-06-16 14:06:02 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Pranith Kumar K 2016-05-11 18:42:59 UTC
+++ This bug was initially created as a clone of Bug #1331860 +++

In libglusterfs/src/syscall.c, line 353, shouldn't XATTR_SECURITY_PREFIX_LEN be used instead of XATTR_TRUSTED_PREFIX_LEN?

https://github.com/gluster/glusterfs/blob/30b66ef3750ece0fb56e673afaca7948d53511e1/libglusterfs/src/syscall.c#L353

--- Additional comment from Atin Mukherjee on 2016-04-30 02:51:45 EDT ---

This doesn't fall into glusterd. Changing the component to core.

--- Additional comment from Vijay Bellur on 2016-05-04 01:23:48 EDT ---

REVIEW: http://review.gluster.org/14194 (libglusterfs: Fix security prefix comparison) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Vijay Bellur on 2016-05-04 07:28:32 EDT ---

COMMIT: http://review.gluster.org/14194 committed in master by Jeff Darcy (jdarcy) 
------
commit 7d431c14bc458e9451e9c737f5879968a7b6a0b9
Author: Pranith Kumar K <pkarampu>
Date:   Wed May 4 10:19:23 2016 +0530

    libglusterfs: Fix security prefix comparison
    
    BUG: 1331860
    Change-Id: If35012ee35104848d7d3b21900c7f533d0253cde
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/14194
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 1 Vijay Bellur 2016-05-11 18:53:53 UTC
REVIEW: http://review.gluster.org/14301 (libglusterfs: Fix security prefix comparison) posted (#1) for review on release-3.8 by Pranith Kumar Karampuri (pkarampu)

Comment 2 Vijay Bellur 2016-05-12 07:03:57 UTC
COMMIT: http://review.gluster.org/14301 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit 54b991b587317a8be06faded01eed4ee046f3bb8
Author: Pranith Kumar K <pkarampu>
Date:   Wed May 4 10:19:23 2016 +0530

    libglusterfs: Fix security prefix comparison
    
     >BUG: 1331860
     >Change-Id: If35012ee35104848d7d3b21900c7f533d0253cde
     >Signed-off-by: Pranith Kumar K <pkarampu>
     >Reviewed-on: http://review.gluster.org/14194
     >Smoke: Gluster Build System <jenkins.com>
     >NetBSD-regression: NetBSD Build System <jenkins.org>
     >CentOS-regression: Gluster Build System <jenkins.com>
     >Reviewed-by: Jeff Darcy <jdarcy>
    
    BUG: 1335282
    Change-Id: Ib2388883d0fd3d777dbc6e856cc44d6179909bfa
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/14301
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2016-06-16 14:06:02 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.