Bug 1331867

Summary:	[RFE] Unable to set number_of_vms in non-generic service catalog items
Product:	Red Hat CloudForms Management Engine	Reporter:	Kevin Morey <kmorey>
Component:	Automate	Assignee:	mkanoor
Status:	CLOSED CURRENTRELEASE	QA Contact:	Milan Falešník <mfalesni>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.5.0	CC:	clasohm, cpelland, gmccullo, jhardy, kmorey, ldomb, mberube, mfalesni, mkanoor, nachandr, nstephan, obarenbo, pmcgowan, simaishi, tfitzger
Target Milestone:	GA	Keywords:	FutureFeature, TestOnly, ZStream
Target Release:	5.7.0
Hardware:	All
OS:	All
Whiteboard:	automate:catalog
Fixed In Version:	5.7.0.0	Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:
Clones:	1333469 1346953 (view as bug list)		Environment:
Last Closed:	2017-01-11 20:20:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1333469, 1346953

Description Kevin Morey 2016-04-29 20:56:00 UTC

Description of problem:
We are missing the ability to set :number_of_vms on vendor based service catalog items. We need this ability to minimize the need to maintain custom "build request" methods utilizing the built-in method "create_provision_request".

Version-Release number of selected component (if applicable):
5.5.3

How reproducible:
100%


Actual results:
when setting option_1_number_of_vms in a service dialog the parameter is always hard-coded to 1.

Expected results:
We need the ability for catalog items to utilize :number_of_vms parameter

Additional info:

Comment 2 Greg McCullough 2016-05-04 21:11:31 UTC

Madhu - Let's discuss the approach here more.  In the last triage meeting PM agreed that this should be a priority.

Comment 4 CFME Bot 2016-05-06 16:40:46 UTC

https://github.com/ManageIQ/manageiq/pull/8515

Comment 6 CFME Bot 2016-07-29 16:30:48 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/da2afe52377446b0dcfb4b661a1392c99b94d1dc

commit da2afe52377446b0dcfb4b661a1392c99b94d1dc
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Mon May 2 09:32:07 2016 -0400
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Thu Jul 28 16:38:21 2016 -0400

    Allow for service templates to have multiple VM's
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1331867
    
    Expose the number_of_vms when building the provision request for
    a service.
    The number_of_vms can be set it multiple places
    
    (1) In the Provision Request
    (2) In the Single Service Item Dialog
    (3) In the Service Bundle Dialog
    (4) Default, allow a single vm under a service

 app/models/miq_provision_request_template.rb       | 29 ++++++++-
 .../__methods__/catalogiteminitialization.rb       | 24 +++----
 .../catalog_item_initialization_spec.rb            |  2 +-
 spec/models/miq_provision_request_template_spec.rb | 74 +++++++++++++++++++++-
 spec/support/service_template_helper.rb            |  9 ++-
 5 files changed, 120 insertions(+), 18 deletions(-)

Comment 7 mkanoor 2016-08-01 18:56:52 UTC

A separate git issue has been opened to handle quota issues.
https://github.com/ManageIQ/manageiq/issues/10145

Comment 9 Greg McCullough 2016-09-07 17:52:43 UTC

Yes, I do want to back-port this to darga.  I'll change the label.  Thanks.

Comment 10 CFME Bot 2016-09-08 16:06:26 UTC

New commit detected on ManageIQ/manageiq/darga:
https://github.com/ManageIQ/manageiq/commit/72fa039dfa5a7ee37ffc2d5e736ffad745731c4f

commit 72fa039dfa5a7ee37ffc2d5e736ffad745731c4f
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Mon May 2 09:32:07 2016 -0400
Commit:     Lucy Fu <lufu>
CommitDate: Thu Sep 8 10:59:22 2016 -0400

    Allow for service templates to have multiple VM's
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1331867
    
    Expose the number_of_vms when building the provision request for
    a service.
    The number_of_vms can be set it multiple places
    
    (1) In the Provision Request
    (2) In the Single Service Item Dialog
    (3) In the Service Bundle Dialog
    (4) Default, allow a single vm under a service

 app/models/miq_provision_request_template.rb       | 29 ++++++++-
 .../__methods__/catalogiteminitialization.rb       | 24 +++----
 .../catalog_item_initialization_spec.rb            |  2 +-
 spec/models/miq_provision_request_template_spec.rb | 74 +++++++++++++++++++++-
 spec/support/service_template_helper.rb            |  9 ++-
 5 files changed, 120 insertions(+), 18 deletions(-)

Comment 11 Milan Falešník 2016-09-16 11:57:28 UTC

Verified in 5.7.0.0

I tried to have a dialog with number_of_vms field and I tried it on a service item and service bundle and the number of vms specified in there was honoured.