Bug 1332074

Summary:	Marker: Lot of dict_get errors in brick log!!
Product:	[Community] GlusterFS	Reporter:	Kotresh HR <khiremat>
Component:	marker	Assignee:	Kotresh HR <khiremat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.7.10	CC:	bugs, simon.fayer05
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1319581	Environment:
Last Closed:	2016-06-28 12:16:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1319581
Bug Blocks:	1335505

Description Kotresh HR 2016-05-02 05:50:49 UTC

+++ This bug was initially created as a clone of Bug #1319581 +++

Description of problem:
There are dict_get errors in the brick log.

Error in log:
[2016-03-21 05:25:03.525473] I [dict.c:463ict_get]
(-->/usr/local/lib/libglusterfs.so.0(default_getxattr_cbk+0xe5)
[0x7f019da0a1f5]
-->/usr/local/lib/glusterfs/3.8dev/xlator/features/marker.so(+0xd27e) [0x7f0191afe27e] -->/usr/local/lib/libglusterfs.so.0(dict_get+0x7e)
[0x7f019d98ac8e] ) 0-dict: !this || key=() [Invalid argument]

Version-Release number of selected component (if applicable):
mainline

How reproducible:
Always

Steps to Reproduce:
When geo-rep.indexing is not enabled and getxattr is done on any xattr.

Actual results:
Dict get error logs are seen

Expected results:
dict_get errors should not be seen.

Additional info:

--- Additional comment from Kotresh HR on 2016-03-21 02:52:31 EDT ---

The issue is reproducible when getxattr is done on any file in gluster mount when geo-rep.indexing is not enabled and quota is enabled.

--- Additional comment from Vijay Bellur on 2016-03-21 02:53:48 EDT ---

REVIEW: http://review.gluster.org/13793 (features/marker: Fix dict_get errors when key is NULL) posted (#1) for review on master by Kotresh HR (khiremat)

--- Additional comment from Mike McCune on 2016-03-28 18:53:35 EDT ---

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

--- Additional comment from Vijay Bellur on 2016-03-29 02:50:27 EDT ---

REVIEW: http://review.gluster.org/13793 (features/marker: Fix dict_get errors when key is NULL) posted (#2) for review on master by Kotresh HR (khiremat)

--- Additional comment from Vijay Bellur on 2016-04-21 07:37:45 EDT ---

COMMIT: http://review.gluster.org/13793 committed in master by Venky Shankar (vshankar) 
------
commit fb55cf6aea208b8f493adc011b3b0a0d734cc8a1
Author: Kotresh HR <khiremat>
Date:   Mon Mar 21 12:01:47 2016 +0530

    features/marker: Fix dict_get errors when key is NULL
    
    Change-Id: I25e497459441334c13af77b3fec83c42a7a92ac4
    BUG: 1319581
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/13793
    Smoke: Gluster Build System <jenkins.com>
    Tested-by: Vijaikumar Mallikarjuna <vmallika>
    Reviewed-by: Vijaikumar Mallikarjuna <vmallika>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Venky Shankar <vshankar>

Comment 1 Vijay Bellur 2016-05-02 05:57:51 UTC

REVIEW: http://review.gluster.org/14144 (features/marker: Fix dict_get errors when key is NULL) posted (#1) for review on release-3.7 by Kotresh HR (khiremat)

Comment 2 Vijay Bellur 2016-05-04 05:46:24 UTC

COMMIT: http://review.gluster.org/14144 committed in release-3.7 by Venky Shankar (vshankar) 
------
commit 5cd344b610c814df8375db7c3144df97766b47bd
Author: Kotresh HR <khiremat>
Date:   Mon Mar 21 12:01:47 2016 +0530

    features/marker: Fix dict_get errors when key is NULL
    
    Backport of:
    >Change-Id: I25e497459441334c13af77b3fec83c42a7a92ac4
    >BUG: 1319581
    >Signed-off-by: Kotresh HR <khiremat>
    >Reviewed-on: http://review.gluster.org/13793
    >Smoke: Gluster Build System <jenkins.com>
    >Tested-by: Vijaikumar Mallikarjuna <vmallika>
    >Reviewed-by: Vijaikumar Mallikarjuna <vmallika>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.com>
    >Reviewed-by: Venky Shankar <vshankar>
    >Signed-off-by: Kotresh HR <khiremat>
    
    Change-Id: I8054ffab3574b6ceb1c7d4290e9f6de3dbf38724
    BUG: 1332074
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/14144
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Venky Shankar <vshankar>

Comment 3 Kaushal 2016-06-28 12:16:31 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report.

glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user