Bug 1332424

Summary:	geo-rep: address potential leak of memory
Product:	[Community] GlusterFS	Reporter:	Prasanna Kumar Kalever <prasanna.kalever>
Component:	geo-replication	Assignee:	Prasanna Kumar Kalever <prasanna.kalever>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	medium
Version:	3.8	CC:	amukherj, bugs, hgowtham, ndevos
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1332419	Environment:
Last Closed:	2016-09-16 18:27:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1332419
Bug Blocks:

Description Prasanna Kumar Kalever 2016-05-03 07:39:06 UTC

+++ This bug was initially created as a clone of Bug #1332419 +++

Description of problem:
address a potential leak of memory in the main() of gsyncd.c


Version-Release number of selected component (if applicable):
mainline

--- Additional comment from Vijay Bellur on 2016-05-03 03:34:32 EDT ---

REVIEW: http://review.gluster.org/14151 (geo-rep: address potential leak of memory) posted (#3) for review on master by Prasanna Kumar Kalever (pkalever)

Comment 1 Worker Ant 2016-09-01 05:00:32 UTC

REVIEW: http://review.gluster.org/15377 (geo-rep: address potential leak of memory) posted (#1) for review on release-3.8 by Atin Mukherjee (amukherj)

Comment 2 Worker Ant 2016-09-01 06:16:50 UTC

REVIEW: http://review.gluster.org/15377 (geo-rep: address potential leak of memory) posted (#2) for review on release-3.8 by Atin Mukherjee (amukherj)

Comment 3 Worker Ant 2016-09-07 14:05:00 UTC

COMMIT: http://review.gluster.org/15377 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit a3f6b608f5c34ca4ded05c3b7dc272d8df68345a
Author: Prasanna Kumar Kalever <prasanna.kalever>
Date:   Mon May 2 19:06:47 2016 +0530

    geo-rep: address potential leak of memory
    
    fix memory leak reported by clang analyzer:
    gsyncd.c:411:17: warning: Potential leak of
                     memory pointed to by 'argv'
                     in main()
    
    
    
    >BUG: 1332419
    >Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    >Reviewed-on: http://review.gluster.org/14151
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >Smoke: Gluster Build System <jenkins.org>
    >Reviewed-by: Kotresh HR <khiremat>
    
    Change-Id: I179fb1c095cf4d331b5910df6388dc724cb4ac96
    BUG: 1332424
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    Change-Id: Id60c851c5462868630349dd4707fd94f1b83e488
    Reviewed-on: http://review.gluster.org/15377
    Tested-by: Atin Mukherjee <amukherj>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Prasanna Kumar Kalever <pkalever>
    Reviewed-by: Niels de Vos <ndevos>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 4 Niels de Vos 2016-09-12 05:39:32 UTC

All 3.8.x bugs are now reported against version 3.8 (without .x). For more information, see http://www.gluster.org/pipermail/gluster-devel/2016-September/050859.html

Comment 5 Niels de Vos 2016-09-16 18:27:59 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.4, please open a new bug report.

glusterfs-3.8.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/announce/2016-September/000060.html
[2] https://www.gluster.org/pipermail/gluster-users/