Bug 1332721 (kf5-libkleo)

Summary: Review Request: kf5-libkleo - KDE PIM cryptographic library
Product: [Fedora] Fedora Reporter: Daniel Vrátil <me>
Component: Package ReviewAssignee: Rex Dieter <rdieter>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, rdieter
Target Milestone: ---Flags: rdieter: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-19 19:27:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 656997, 1332720, 1332722    

Description Daniel Vrátil 2016-05-03 22:39:02 UTC 
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-libkleo.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-libkleo-16.04.0-1.fc23.src.rpm
Description: KDE PIM cryptographic library
Fedora Account System Username: dvratil
Comment 1 Rex Dieter 2016-05-19 17:56:08 UTC 
naming: ok

sources: ok
910bc749dd4684b5935ecabf2f53fb54  libkleo-16.04.0.tar.xz

URL: Not valid
1.  Should fix URL to (something like):
URL:     https://quickgit.kde.org/?p=%{framework}.git

2.  Should tighten cmake(KF5...) related BuildRequires

macros: ok

scriptlets: ok


looks good APPROVED, can address non-blocking SHOULD items after import
Comment 2 Rex Dieter 2016-05-19 17:59:26 UTC 
pkgdb request submitted
Comment 3 Gwyn Ciesla 2016-05-19 19:13:56 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-libkleo
Comment 4 Rex Dieter 2016-05-19 19:27:52 UTC 
imported, waiting to do builds until rest of stack is reviewed/ready