Bug 1332721 (kf5-libkleo) - Review Request: kf5-libkleo - KDE PIM cryptographic library
Summary: Review Request: kf5-libkleo - KDE PIM cryptographic library
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-libkleo
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kdepim-addons kleopatra
TreeView+ depends on / blocked
 
Reported: 2016-05-03 22:39 UTC by Daniel Vrátil
Modified: 2016-05-19 19:27 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-05-19 19:27:52 UTC
Type: ---
Embargoed:
rdieter: fedora-review+

Attachments (Terms of Use)

Description Daniel Vrátil 2016-05-03 22:39:02 UTC 
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-libkleo.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-libkleo-16.04.0-1.fc23.src.rpm
Description: KDE PIM cryptographic library
Fedora Account System Username: dvratil
Comment 1 Rex Dieter 2016-05-19 17:56:08 UTC 
naming: ok

sources: ok
910bc749dd4684b5935ecabf2f53fb54  libkleo-16.04.0.tar.xz

URL: Not valid
1.  Should fix URL to (something like):
URL:     https://quickgit.kde.org/?p=%{framework}.git

2.  Should tighten cmake(KF5...) related BuildRequires

macros: ok

scriptlets: ok


looks good APPROVED, can address non-blocking SHOULD items after import
Comment 2 Rex Dieter 2016-05-19 17:59:26 UTC 
pkgdb request submitted
Comment 3 Gwyn Ciesla 2016-05-19 19:13:56 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-libkleo
Comment 4 Rex Dieter 2016-05-19 19:27:52 UTC 
imported, waiting to do builds until rest of stack is reviewed/ready
Note You need to log in before you can comment on or make changes to this bug.