Bug 1332788

Summary:	Wrong op-version for mandatory-locks volume set option
Product:	[Community] GlusterFS	Reporter:	Anoop C S <anoopcs>
Component:	glusterd	Assignee:	Anoop C S <anoopcs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.8.0	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1332413	Environment:
Last Closed:	2016-06-16 14:05:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1332413
Bug Blocks:	1317278

Description Anoop C S 2016-05-04 05:46:40 UTC

+++ This bug was initially created as a clone of Bug #1332413 +++

Description of problem:
Mandatory-locks feature has gone into release-3.8 branch. But locks.mandatory-locking volume set option is defined under op-version 4.0.0 which is wrong.

         { .key         = "locks.mandatory-locking",
           .voltype     = "features/locks",
           .op_versionGD_OP_VERSION_4_0_0,
           .validate_fn = validate_mandatory_locking,
         },

Version-Release number of selected component (if applicable):
mainline

--- Additional comment from Vijay Bellur on 2016-05-03 12:55:30 IST ---

REVIEW: http://review.gluster.org/14180 (mgmt/glusterd: Fix op-version for mandatory-locking volume set option) posted (#1) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-05-03 23:38:49 IST ---

COMMIT: http://review.gluster.org/14180 committed in master by Atin Mukherjee (amukherj) 
------
commit 717e66a799b70c9b61ad56ab9d27915e265f9d3d
Author: Anoop C S <anoopcs>
Date:   Tue May 3 12:50:51 2016 +0530

    mgmt/glusterd: Fix op-version for mandatory-locking volume set option
    
    The following volume set option will be available with 3.8 release.
    
    locks.mandatory-locking
    
    This one-line change is to fix the wrongly set op-version for the
    above mentioned volume set option.
    
    Change-Id: Icc7d213f917f5f69e2ec84c685b1138ce2f86a90
    BUG: 1332413
    Signed-off-by: Anoop C S <anoopcs>
    Reviewed-on: http://review.gluster.org/14180
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 1 Vijay Bellur 2016-05-04 05:48:33 UTC

REVIEW: http://review.gluster.org/14195 (mgmt/glusterd: Fix op-version for mandatory-locking volume set option) posted (#1) for review on release-3.8 by Anoop C S (anoopcs)

Comment 2 Vijay Bellur 2016-05-05 09:27:57 UTC

COMMIT: http://review.gluster.org/14195 committed in release-3.8 by Atin Mukherjee (amukherj) 
------
commit 8e84d209b747c3ad067a263b1faea25aba981c20
Author: Anoop C S <anoopcs>
Date:   Tue May 3 12:50:51 2016 +0530

    mgmt/glusterd: Fix op-version for mandatory-locking volume set option
    
    The following volume set option will be available with 3.8 release.
    
    locks.mandatory-locking
    
    This one-line change is to fix the wrongly set op-version for the
    above mentioned volume set option.
    
    > Reviewed-on: http://review.gluster.org/14180
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Smoke: Gluster Build System <jenkins.com>
    > Reviewed-by: Atin Mukherjee <amukherj>
    > CentOS-regression: Gluster Build System <jenkins.com>
    
    (cherry picked from commit 717e66a799b70c9b61ad56ab9d27915e265f9d3d)
    
    Change-Id: Icc7d213f917f5f69e2ec84c685b1138ce2f86a90
    BUG: 1332788
    Signed-off-by: Anoop C S <anoopcs>
    Reviewed-on: http://review.gluster.org/14195
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 3 Niels de Vos 2016-06-16 14:05:07 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user