Bug 1332789

Summary:	quota: client gets IO error instead of disk quota exceed when the limit is exceeded
Product:	[Community] GlusterFS	Reporter:	Raghavendra G <rgowdapp>
Component:	quota	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8.0	CC:	bugs, smohan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1292020
Clones:	1332790 (view as bug list)		Environment:
Last Closed:	2016-06-16 14:05:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1292020
Bug Blocks:	1332790

Description Raghavendra G 2016-05-04 05:51:29 UTC

+++ This bug was initially created as a clone of Bug #1292020 +++

Getting IO error instead of disk quota exceed when the limit is exceeded

# gluster volume create vol1 rh1:/var/opt/gluster/bricks/b1/dir
# gluster volume start vol1
# gluster volume quota vol1 enable
# gluster volume quota vol1 limit-usage / 1

# cd /mnt
# dd if=/dev/zero of=f1 bs=256k count=100
dd: writing `f1': Input/output error
dd: closing output file `f1': Input/output error

--- Additional comment from Vijay Bellur on 2015-12-16 04:29:52 EST ---

REVIEW: http://review.gluster.org/12978 (quota: success is returned when disk quota is exceeded) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Vijay Bellur on 2015-12-16 04:44:06 EST ---

REVIEW: http://review.gluster.org/12978 (quota: success is returned when disk quota is exceeded) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Vijay Bellur on 2015-12-16 04:48:20 EST ---

REVIEW: http://review.gluster.org/12978 (quota: success is returned when disk quota is exceeded) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Vijay Bellur on 2015-12-16 07:21:48 EST ---

REVIEW: http://review.gluster.org/12981 (quota: success is returned when disk quota is exceeded) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Vijay Bellur on 2015-12-16 07:25:07 EST ---

REVIEW: http://review.gluster.org/12981 (quota: success is returned when disk quota is exceeded) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Vijay Bellur on 2015-12-16 08:06:55 EST ---

REVIEW: http://review.gluster.org/12981 (quota: set op_errno when a partial write done because of exceeding limit) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Vijay Bellur on 2016-02-12 07:11:49 EST ---

REVIEW: http://review.gluster.org/13438 (performance/write-behind: guaranteed retry after a short write) posted (#1) for review on master by Raghavendra G (rgowdapp)

--- Additional comment from Mike McCune on 2016-03-28 19:44:20 EDT ---

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

--- Additional comment from Vijay Bellur on 2016-04-06 22:46:39 EDT ---

REVIEW: http://review.gluster.org/13438 (performance/write-behind: guaranteed retry after a short write) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Vijay Bellur on 2016-05-03 23:27:05 EDT ---

REVIEW: http://review.gluster.org/13438 (performance/write-behind: guaranteed retry after a short write) posted (#3) for review on master by Raghavendra G (rgowdapp)

Comment 1 Vijay Bellur 2016-05-04 05:55:07 UTC

REVIEW: http://review.gluster.org/14197 (performance/write-behind: guaranteed retry after a short write) posted (#1) for review on release-3.8 by Raghavendra G (rgowdapp)

Comment 2 Vijay Bellur 2016-05-05 03:27:13 UTC

COMMIT: http://review.gluster.org/14197 committed in release-3.8 by Raghavendra G (rgowdapp) 
------
commit 80564355aaf15ba7c9b57daeb22f38f3f4f66684
Author: Raghavendra G <rgowdapp>
Date:   Fri Feb 12 17:17:30 2016 +0530

    performance/write-behind: guaranteed retry after a short write
    
    * Don't mark the request with a fake EIO after a short write.
    * retry the remaining buffer at least once before unwinding reply to
      application. This way we capture correct error from backend (ENOSPC,
      EDQUOT etc).
    
    Thanks to "Vijaikumar Mallikarjuna"<vmallika> for the test
    script.
    
    Change-Id: I73a18b39b661a7424db1a7855a980469a51da8f9
    BUG: 1332789
    Signed-off-by: Raghavendra G <rgowdapp>
    Reviewed-on: http://review.gluster.org/14197
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 3 Niels de Vos 2016-06-16 14:05:07 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user