Bug 1332838

Summary:	rpc: assign port only if it is unreserved
Product:	[Community] GlusterFS	Reporter:	Prasanna Kumar Kalever <prasanna.kalever>
Component:	rpc	Assignee:	Prasanna Kumar Kalever <prasanna.kalever>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.11	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1323659	Environment:
Last Closed:	2016-06-28 12:16:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1323659
Bug Blocks:

Description Prasanna Kumar Kalever 2016-05-04 07:41:18 UTC

+++ This bug was initially created as a clone of Bug #1323659 +++

Description of problem:
basically we are assigning port first then checking if it is reserved

Version-Release number of selected component (if applicable):
mainline

Fix:
we get unreserved port first and then assign it

--- Additional comment from Vijay Bellur on 2016-04-04 07:25:04 EDT ---

REVIEW: http://review.gluster.org/13900 (rpc: assign port only if it is unreserved) posted (#1) for review on master by Prasanna Kumar Kalever (pkalever)

--- Additional comment from Vijay Bellur on 2016-04-04 07:34:02 EDT ---

REVIEW: http://review.gluster.org/13900 (rpc: assign port only if it is unreserved) posted (#2) for review on master by Prasanna Kumar Kalever (pkalever)

--- Additional comment from Vijay Bellur on 2016-04-06 13:08:50 EDT ---

COMMIT: http://review.gluster.org/13900 committed in master by Raghavendra G (rgowdapp) 
------
commit 7370633b6404bbd3c8238b464bc413689dcccf93
Author: Prasanna Kumar Kalever <prasanna.kalever>
Date:   Mon Apr 4 16:15:18 2016 +0530

    rpc: assign port only if it is unreserved
    
    Current order:
        assign port;
        check for port;
        if reserved {
            port--;
            continue to i;
        }
        bind();
    
    basically, we are assigning port first then checking if it is reserved
    
    Fix:
        get unreserved port;
        assign port;
        bind();
    
    from now, we get unreserved port first and then assign it
    
    Change-Id: I004580c5215e7c9cae3594af6405b20fcd9fa4ad
    BUG: 1323659
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    Reviewed-on: http://review.gluster.org/13900
    Tested-by: Prasanna Kumar Kalever <pkalever>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jdarcy>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Talur <rtalur>
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 1 Vijay Bellur 2016-05-04 07:57:00 UTC

REVIEW: http://review.gluster.org/14204 (rpc: assign port only if it is unreserved) posted (#1) for review on release-3.7 by Prasanna Kumar Kalever (pkalever)

Comment 2 Vijay Bellur 2016-05-05 03:24:35 UTC

COMMIT: http://review.gluster.org/14204 committed in release-3.7 by Raghavendra G (rgowdapp) 
------
commit 8f6ab172c9817638f9032ed4436423efd8f8c56c
Author: Prasanna Kumar Kalever <prasanna.kalever>
Date:   Mon Apr 4 16:15:18 2016 +0530

    rpc: assign port only if it is unreserved
    
    Current order:
        assign port;
        check for port;
        if reserved {
            port--;
            continue to i;
        }
        bind();
    
    basically, we are assigning port first then checking if it is reserved
    
    Fix:
        get unreserved port;
        assign port;
        bind();
    
    from now, we get unreserved port first and then assign it
    
    Backport of:
    > Change-Id: I004580c5215e7c9cae3594af6405b20fcd9fa4ad
    > BUG: 1323659
    > Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    > Reviewed-on: http://review.gluster.org/13900
    > Tested-by: Prasanna Kumar Kalever <pkalever>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Reviewed-by: Jeff Darcy <jdarcy>
    > CentOS-regression: Gluster Build System <jenkins.com>
    > Reviewed-by: Raghavendra Talur <rtalur>
    > Smoke: Gluster Build System <jenkins.com>
    > Reviewed-by: Raghavendra G <rgowdapp>
    > Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    
    Change-Id: I772c1323606f1853542e22d8ab4d80934871efcb
    BUG: 1332838
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    Reviewed-on: http://review.gluster.org/14204
    Tested-by: Prasanna Kumar Kalever <pkalever>
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 3 Kaushal 2016-06-28 12:16:31 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report.

glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user