Bug 1333874

Summary:	Automate \| Services \| Remove ConfigureChildDialog method and state value.
Product:	Red Hat CloudForms Management Engine	Reporter:	Tina Fitzgerald <tfitzger>
Component:	Automate	Assignee:	William Fitzgerald <wfitzger>
Status:	CLOSED ERRATA	QA Contact:	Milan Falešník <mfalesni>
Severity:	low	Docs Contact:
Priority:	low
Version:	5.6.0	CC:	cpelland, dajohnso, jhardy, jprause, mfalesni, mkanoor, obarenbo, simaishi, tfitzger, wfitzger
Target Milestone:	GA	Keywords:	ZStream
Target Release:	5.6.0	Flags:	mfalesni: automate_bug-
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	automate:service:dialog
Fixed In Version:	5.6.0.8	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1353231 (view as bug list)		Environment:
Last Closed:	2016-06-29 16:00:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1353231

Description Tina Fitzgerald 2016-05-06 14:18:53 UTC

Description of problem:
ConfigureChildDialog is a method and state in the service state machine. It was created to be used as an example of how you could pass dialog information to a task. The ConfigureChildDialog service state relationship has always been commented out. The method is outdated and should be removed and the state entry should be cleared.  

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 CFME Bot 2016-05-17 15:00:55 UTC

https://github.com/ManageIQ/manageiq/pull/8757

Comment 3 CFME Bot 2016-05-18 16:55:52 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/9d7b45cdfdb3b23dcfff20173a71480359fe5e29

commit 9d7b45cdfdb3b23dcfff20173a71480359fe5e29
Author:     william fitzgerald <wfitzger>
AuthorDate: Tue May 17 09:51:49 2016 -0400
Commit:     william fitzgerald <wfitzger>
CommitDate: Tue May 17 12:56:23 2016 -0400

    Automate | Services | Remove ConfigureChildDialog method and state value.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1333874
    
    Removed instance, method and value in schema for ConfigureChildDialog
    
    in Service/Provisioning/StateMachines/Methods.class.

 .../__methods__/configurechilddialog.rb            | 55 ----------------------
 .../Methods.class/configurechilddialog.yaml        | 12 -----
 .../ServiceProvision_Template.class/__class__.yaml |  2 +-
 3 files changed, 1 insertion(+), 68 deletions(-)
 delete mode 100644 db/fixtures/ae_datastore/ManageIQ/Service/Provisioning/StateMachines/Methods.class/__methods__/configurechilddialog.rb
 delete mode 100644 db/fixtures/ae_datastore/ManageIQ/Service/Provisioning/StateMachines/Methods.class/configurechilddialog.yaml

Comment 5 William Fitzgerald 2016-06-13 18:09:54 UTC

Milan,

I have a followup PR to remove the configurechilddialog.yaml.

https://github.com/ManageIQ/manageiq/pull/9080/files is being reviewed.

Bill

Comment 6 Milan Falešník 2016-06-17 13:01:32 UTC

Marking this bug as verified. Although the PR Bill mentioned has not made it to to 5.6.0.11-rc2.2 yet.

I noticed that the Openshift Installer in the RedHat domain uses this method, I will file a bug against that.

Comment 8 errata-xmlrpc 2016-06-29 16:00:05 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348