Bug 1334621

Summary: set errno in case of inode_link failures
Product: [Community] GlusterFS Reporter: Soumya Koduri <skoduri>
Component: libgfapiAssignee: Soumya Koduri <skoduri>
Status: CLOSED CURRENTRELEASE QA Contact: Sudhir D <sdharane>
Severity: medium Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: glusterfs-3.9.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1334852 1334854 1335016 1335017 1335029 (view as bug list) Environment:
Last Closed: 2017-03-27 18:10:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1333546, 1334852, 1334854, 1335016, 1335017, 1335029    

Description Soumya Koduri 2016-05-10 07:42:55 UTC 
Description of problem:

Currently gfapi does not seem to be setting errno appropriately in case of inode_link failures. This may cause mislead applications (for eg., nfs-ganesha) which rely on errno to determine the error encountered. 


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Vijay Bellur 2016-05-10 07:44:07 UTC 
REVIEW: http://review.gluster.org/14278 (gfapi: set errno for inode_link failures) posted (#1) for review on master by soumya k (skoduri)
Comment 2 Vijay Bellur 2016-05-10 10:08:26 UTC 
REVIEW: http://review.gluster.org/14278 (libglusterfs/gfapi: set appropriate errno for inode_link failures) posted (#2) for review on master by soumya k (skoduri)
Comment 3 Vijay Bellur 2016-05-10 11:42:01 UTC 
REVIEW: http://review.gluster.org/14278 (libglusterfs/gfapi: set appropriate errno for inode_link failures) posted (#3) for review on master by soumya k (skoduri)
Comment 4 Vijay Bellur 2016-05-10 16:10:28 UTC 
COMMIT: http://review.gluster.org/14278 committed in master by Niels de Vos (ndevos) 
------
commit 176724cdec7061ead0bd7497bb56d0ac09a668a7
Author: Soumya Koduri <skoduri>
Date:   Tue May 10 13:03:42 2016 +0530

    libglusterfs/gfapi: set appropriate errno for inode_link failures
    
    We do not seem to be setting errno appropriately in case
    of inode_link failures. This errno may be used by any application
    (for eg., nfs-ganesha) to determine the error encountered. This
    patch addresses the same.
    
    Change-Id: I674f747c73369d0597a9c463e6ea4c85b9091355
    BUG: 1334621
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: http://review.gluster.org/14278
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: jiffin tony Thottan <jthottan>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    CentOS-regression: Gluster Build System <jenkins.com>
Comment 5 Shyamsundar 2017-03-27 18:10:35 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/