Bug 1334854 - set errno in case of inode_link failures
Summary: set errno in case of inode_link failures
Keywords:
Status: CLOSED DUPLICATE of bug 1335016
Alias: None
Product: GlusterFS
Classification: Community
Component: libgfapi
Version: 3.7.11
Hardware: All
OS: All
unspecified
medium
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact: Sudhir D
URL:
Whiteboard:
Depends On: 1334621 1335016 1335017
Blocks: 1335029
TreeView+ depends on / blocked
 
Reported: 2016-05-10 16:14 UTC by Niels de Vos
Modified: 2016-05-30 09:09 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 1334621
Environment:
Last Closed: 2016-05-30 09:06:17 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2016-05-10 16:14:34 UTC
+++ This bug was initially created as a clone of Bug #1334621 +++

Description of problem:

Currently gfapi does not seem to be setting errno appropriately in case of inode_link failures. This may cause mislead applications (for eg., nfs-ganesha) which rely on errno to determine the error encountered. 


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-05-10 09:44:07 CEST ---

REVIEW: http://review.gluster.org/14278 (gfapi: set errno for inode_link failures) posted (#1) for review on master by soumya k (skoduri)

--- Additional comment from Vijay Bellur on 2016-05-10 12:08:26 CEST ---

REVIEW: http://review.gluster.org/14278 (libglusterfs/gfapi: set appropriate errno for inode_link failures) posted (#2) for review on master by soumya k (skoduri)

--- Additional comment from Vijay Bellur on 2016-05-10 13:42:01 CEST ---

REVIEW: http://review.gluster.org/14278 (libglusterfs/gfapi: set appropriate errno for inode_link failures) posted (#3) for review on master by soumya k (skoduri)

--- Additional comment from Vijay Bellur on 2016-05-10 18:10:28 CEST ---

COMMIT: http://review.gluster.org/14278 committed in master by Niels de Vos (ndevos) 
------
commit 176724cdec7061ead0bd7497bb56d0ac09a668a7
Author: Soumya Koduri <skoduri>
Date:   Tue May 10 13:03:42 2016 +0530

    libglusterfs/gfapi: set appropriate errno for inode_link failures
    
    We do not seem to be setting errno appropriately in case
    of inode_link failures. This errno may be used by any application
    (for eg., nfs-ganesha) to determine the error encountered. This
    patch addresses the same.
    
    Change-Id: I674f747c73369d0597a9c463e6ea4c85b9091355
    BUG: 1334621
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: http://review.gluster.org/14278
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: jiffin tony Thottan <jthottan>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 1 Niels de Vos 2016-05-30 09:06:17 UTC

*** This bug has been marked as a duplicate of bug 1335016 ***


Note You need to log in before you can comment on or make changes to this bug.