Bug 1335016

Summary:	set errno in case of inode_link failures
Product:	[Community] GlusterFS	Reporter:	Soumya Koduri <skoduri>
Component:	libgfapi	Assignee:	Soumya Koduri <skoduri>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sudhir D <sdharane>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.7.11	CC:	bugs, ndevos, olim, sdharane
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.7.12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1334621	Environment:
Last Closed:	2016-06-28 12:17:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1334621, 1335017
Bug Blocks:	1333546, 1334854

Description Soumya Koduri 2016-05-11 07:08:28 UTC

+++ This bug was initially created as a clone of Bug #1334621 +++

Description of problem:

Currently gfapi does not seem to be setting errno appropriately in case of inode_link failures. This may cause mislead applications (for eg., nfs-ganesha) which rely on errno to determine the error encountered. 


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-05-10 03:44:07 EDT ---

REVIEW: http://review.gluster.org/14278 (gfapi: set errno for inode_link failures) posted (#1) for review on master by soumya k (skoduri)

--- Additional comment from Vijay Bellur on 2016-05-10 06:08:26 EDT ---

REVIEW: http://review.gluster.org/14278 (libglusterfs/gfapi: set appropriate errno for inode_link failures) posted (#2) for review on master by soumya k (skoduri)

--- Additional comment from Vijay Bellur on 2016-05-10 07:42:01 EDT ---

REVIEW: http://review.gluster.org/14278 (libglusterfs/gfapi: set appropriate errno for inode_link failures) posted (#3) for review on master by soumya k (skoduri)

--- Additional comment from Vijay Bellur on 2016-05-10 12:10:28 EDT ---

COMMIT: http://review.gluster.org/14278 committed in master by Niels de Vos (ndevos) 
------
commit 176724cdec7061ead0bd7497bb56d0ac09a668a7
Author: Soumya Koduri <skoduri>
Date:   Tue May 10 13:03:42 2016 +0530

    libglusterfs/gfapi: set appropriate errno for inode_link failures
    
    We do not seem to be setting errno appropriately in case
    of inode_link failures. This errno may be used by any application
    (for eg., nfs-ganesha) to determine the error encountered. This
    patch addresses the same.
    
    Change-Id: I674f747c73369d0597a9c463e6ea4c85b9091355
    BUG: 1334621
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: http://review.gluster.org/14278
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: jiffin tony Thottan <jthottan>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 1 Vijay Bellur 2016-05-11 07:13:42 UTC

REVIEW: http://review.gluster.org/14287 (libglusterfs/gfapi: set appropriate errno for inode_link failures) posted (#1) for review on release-3.7 by soumya k (skoduri)

Comment 2 Vijay Bellur 2016-05-11 14:36:36 UTC

COMMIT: http://review.gluster.org/14287 committed in release-3.7 by Kaleb KEITHLEY (kkeithle) 
------
commit 44cf0aa02bf081d0b94d0174493cbf162dd957b8
Author: Soumya Koduri <skoduri>
Date:   Tue May 10 13:03:42 2016 +0530

    libglusterfs/gfapi: set appropriate errno for inode_link failures
    
    We do not seem to be setting errno appropriately in case
    of inode_link failures. This errno may be used by any application
    (for eg., nfs-ganesha) to determine the error encountered. This
    patch addresses the same.
    
    This is backport of below mainline fix -
            http://review.gluster.org/14278
    
    Change-Id: I674f747c73369d0597a9c463e6ea4c85b9091355
    BUG: 1335016
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: http://review.gluster.org/14278
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: jiffin tony Thottan <jthottan>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/14287
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 3 Niels de Vos 2016-05-30 09:06:17 UTC

*** Bug 1334854 has been marked as a duplicate of this bug. ***

Comment 4 Kaushal 2016-06-28 12:17:24 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report.

glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user