Bug 1335813

Summary:	rpc: change client insecure port ceiling from 65535 to 49151
Product:	[Community] GlusterFS	Reporter:	Prasanna Kumar Kalever <prasanna.kalever>
Component:	rpc	Assignee:	Prasanna Kumar Kalever <prasanna.kalever>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.11	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1335776
Clones:	1335815 (view as bug list)		Environment:
Last Closed:	2016-06-28 12:17:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1335776
Bug Blocks:	1335815

Description Prasanna Kumar Kalever 2016-05-13 09:27:27 UTC

+++ This bug was initially created as a clone of Bug #1335776 +++

Description of problem:
current port allocation to various processes (clumsy):
    
 1023 - 1       -> client ports range if bind secure is turned on
49151 - 1024    -> fall back to this, if in above case ports exhaust
65535 - 1024    -> client port range if bind insecure is on
49152 - 65535   -> brick port range
    
now, we should have segregated port ranges 0 - 65535 to below 3 ranges
    
 1023 - 1       -> client ports range if bind secure is turned on
49151 - 1024    -> client port range if bind insecure is on
                   (fall back to this, if in above case ports exhaust)
49152 - 65535   -> brick port range
    
for a cleaner way of segregation this is necessary, and since  bind insecure
is on by default, there could be a chance of port clashes between brick and clients

Version-Release number of selected component (if applicable):
3.7.11

--- Additional comment from Vijay Bellur on 2016-05-13 04:20:20 EDT ---

REVIEW: http://review.gluster.org/14326 (rpc: change client insecure port ceiling from 65535 to 49151) posted (#1) for review on master by Prasanna Kumar Kalever (pkalever)

Comment 1 Vijay Bellur 2016-05-18 10:53:49 UTC

REVIEW: http://review.gluster.org/14412 (rpc: change client insecure port ceiling from 65535 to 49151) posted (#1) for review on release-3.7 by Prasanna Kumar Kalever (pkalever)

Comment 2 Vijay Bellur 2016-05-20 10:55:38 UTC

COMMIT: http://review.gluster.org/14412 committed in release-3.7 by Raghavendra G (rgowdapp) 
------
commit fdf91b713658b83936383dc53b0f241876f5ead1
Author: Prasanna Kumar Kalever <prasanna.kalever>
Date:   Fri May 13 13:17:16 2016 +0530

    rpc: change client insecure port ceiling from 65535 to 49151
    
    current port allocation to various processes (clumsy):
    
     1023 - 1       -> client ports range if bind secure is turned on
    49151 - 1024    -> fall back to this, if in above case ports exhaust
    65535 - 1024    -> client port range if bind insecure is on
    49152 - 65535   -> brick port range
    
    now, we have segregated port ranges 0 - 65535 to below 3 ranges
    
     1023 - 1       -> client ports range if bind secure is turned on
    49151 - 1024    -> client port range if bind insecure is on
                       (fall back to this, if in above case ports exhaust)
    49152 - 65535   -> brick port range
    
    so now we have a clean segregation of port mapping
    
    Backport of:
    > Change-Id: Ie3b4e7703e0bbeabbe0adbdd6c60d9ef78ef7c65
    > BUG: 1335776
    > Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    > Reviewed-on: http://review.gluster.org/14326
    > Tested-by: Prasanna Kumar Kalever <pkalever>
    > Reviewed-by: Raghavendra Talur <rtalur>
    > Tested-by: Gluster Build System <jenkins.com>
    > CentOS-regression: Gluster Build System <jenkins.com>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Smoke: Gluster Build System <jenkins.com>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle>
    > Reviewed-by: Raghavendra G <rgowdapp>
    
    Change-Id: Ie3b4e7703e0bbeabbe0adbdd6c60d9ef78ef7c65
    BUG: 1335813
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    Reviewed-on: http://review.gluster.org/14412
    Tested-by: Prasanna Kumar Kalever <pkalever>
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 3 Kaushal 2016-06-28 12:17:59 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report.

glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user